Summary

Modernize rbslack and add a deprecation warning.

Review Request #11058 — Created June 25, 2020 and submitted July 6, 2020, 11:18 a.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

I've also decided to add a warning to the extension's description that
it is deprecated and will be removed soon, so hopefully all this work is
actually moot.

Testing Done

Loaded the slack integration and saw that things worked as expected.

Commits

Summary	ID
Modernize rbslack and add a deprecation warning. This change modernizes the rbslack extension to work with Review Board 4.0 and Django 1.11. This involves updating the urlpatterns and the handler for the review_request_closed signal, and fixing up documentation throughout. I've also decided to add a warning to the extension's description that it is deprecated and will be removed soon, so hopefully all this work is actually moot. Testing Done: Loaded the slack integration and saw that things worked as expected.	116a13158b568a75ade41998760e5f9ad3e64c5c

Summary

Modernize rbslack and add a deprecation warning.

This change modernizes the rbslack extension to work with Review Board 4.0 and Django 1.11. This involves updating the urlpatterns and the handler for the review_request_closed signal, and fixing up documentation throughout. I've also decided to add a warning to the extension's description that it is deprecated and will be removed soon, so hopefully all this work is actually moot. Testing Done: Loaded the slack integration and saw that things worked as expected.

116a13158b568a75ade41998760e5f9ad3e64c5c

Issues

Description	From	Last Updated
These should be in the same import group.	chipx86	June 30, 2020, 1:09 p.m.
Same nit.	chipx86	June 30, 2020, 1:10 p.m.
Nit: Can you move the ) to the following line? That's more in line with how we tend to have …	chipx86	June 30, 2020, 1:16 p.m.

flake8 passed.

JSHint passed.

rbslack/rbslack/admin_urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
These should be in the same import group.
```
rbslack/rbslack/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same nit.
```

rbslack/setup.py (Diff revision 1)

The issue has been resolved. Show all issues

Nit: Can you move the ) to the following line? That's more in line with how we tend to have multi-line strings.

Summary:

Update rbslack urlpatterns and add a deprecation warning.

Modernize rbslack and add a deprecation warning.

Description:

~		This change updates rbslack to work with the new Django urlpatterns
~		requirements (moving away from urlpatterns), and also adds a warning to
~		the extension's description that it is deprecated and will be removed
~		soon.
	~	This change modernizes the rbslack extension to work with Review Board
	~	4.0 and Django 1.11. This involves updating the urlpatterns and the
	~	handler for the review_request_closed signal, and fixing up
	~	documentation throughout.
	+
	+	I've also decided to add a warning to the extension's description that
	+	it is deprecated and will be removed soon, so hopefully all this work is
	+	actually moot.

Commits:

	Summary	ID
	Update rbslack urlpatterns and add a deprecation warning. This change updates rbslack to work with the new Django urlpatterns requirements (moving away from urlpatterns), and also adds a warning to the extension's description that it is deprecated and will be removed soon. Testing Done: Loaded the slack integration and saw that things worked as expected.	09292a56931e5436d12683ab380c58dff599b19f
	Modernize rbslack and add a deprecation warning. This change modernizes the rbslack extension to work with Review Board 4.0 and Django 1.11. This involves updating the urlpatterns and the handler for the review_request_closed signal, and fixing up documentation throughout. I've also decided to add a warning to the extension's description that it is deprecated and will be removed soon, so hopefully all this work is actually moot. Testing Done: Loaded the slack integration and saw that things worked as expected.	116a13158b568a75ade41998760e5f9ad3e64c5c

Diff:

Revision 2 (+354 -44)

Show changes

	rbslack/setup.py
	rbslack/rbslack/__init__.py
	rbslack/rbslack/admin_urls.py
	rbslack/rbslack/extension.py
	rbslack/rbslack/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (d674589)