Modernize rbslack and add a deprecation warning.
Review Request #11058 — Created June 25, 2020 and submitted
This change modernizes the rbslack extension to work with Review Board
4.0 and Django 1.11. This involves updating the urlpatterns and the
handler for the review_request_closed signal, and fixing up
documentation throughout.I've also decided to add a warning to the extension's description that
it is deprecated and will be removed soon, so hopefully all this work is
actually moot.
Loaded the slack integration and saw that things worked as expected.
- Summary:
-
Update rbslack urlpatterns and add a deprecation warning.Modernize rbslack and add a deprecation warning.
- Description:
-
~ This change updates rbslack to work with the new Django urlpatterns
~ requirements (moving away from urlpatterns), and also adds a warning to ~ the extension's description that it is deprecated and will be removed ~ soon. ~ This change modernizes the rbslack extension to work with Review Board
~ 4.0 and Django 1.11. This involves updating the urlpatterns and the ~ handler for the review_request_closed signal, and fixing up ~ documentation throughout. + + I've also decided to add a warning to the extension's description that
+ it is deprecated and will be removed soon, so hopefully all this work is + actually moot. - Commits:
-
Summary ID 09292a56931e5436d12683ab380c58dff599b19f 116a13158b568a75ade41998760e5f9ad3e64c5c
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.