flake8
passed.
JSHint
passed.
Update rbmotd for Review Board 4.0
Review Request #11057 — Created June 25, 2020 and submitted
| Information | |
|---|---|
| david | |
| rb-extension-pack | |
| master | |
| Reviewers | |
| rb-extension-pack | |
This change updates the message of the day extension for changes in
Review Board 4.0. This includes moving away from the oldpatterns
method for creating urlpatterns, and updating for API changes in Djblets
config forms. This also modernizes the codebase a bit, adding
unicode_literalsand docstrings.
Activated and configured the motd extension. Verified that everything
worked as expected.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
These should be in the same import group. While here, can you add the standard unicode_literals import? |
 chipx86
|
|
|
Can you add some docs while you're here? Took me a few to figure out what this was doing (with … |
chipx86
|
|
|
"Board" |
chipx86
|
|
|
Probably MotdExtension would be appropriate here. |
chipx86
|
|
|
This would be SafeText. SafeString is bytes on Python 2. |
chipx86
|
|
|
We've only been using * for JavaScript, since there's no base object. For Python, we've been using object. |
chipx86
|
|
|
The module is still safestring, just the class is SafeText. |
chipx86
|
-
-
rbmotd/rbmotd/admin_urls.py (Diff revision 1) These should be in the same import group.
While here, can you add the standard
unicode_literalsimport? -
rbmotd/rbmotd/forms.py (Diff revision 1) Can you add some docs while you're here? Took me a few to figure out what this was doing (with the self-call to
set_key_value()).
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||
Diff: |
Revision 2 (+118 -28) |
||||||||||||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
Looks good. A couple small doc nits.
-
-
-
rbmotd/rbmotd/extension.py (Diff revision 2) This would be
SafeText.SafeStringisbyteson Python 2. -
rbmotd/rbmotd/forms.py (Diff revision 2) We've only been using
*for JavaScript, since there's no base object. For Python, we've been usingobject.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+118 -28) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
rbmotd/rbmotd/extension.py (Diff revision 3) The module is still
safestring, just the class isSafeText.