Summary

Update rbmotd for Review Board 4.0

Review Request #11057 — Created June 25, 2020 and submitted June 30, 2020, 1:06 p.m.

Information

Owner

david

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

This change updates the message of the day extension for changes in
Review Board 4.0. This includes moving away from the old patterns
method for creating urlpatterns, and updating for API changes in Djblets
config forms. This also modernizes the codebase a bit, adding
unicode_literals and docstrings.

Testing Done

Activated and configured the motd extension. Verified that everything
worked as expected.

Commits

Summary	ID
[rbmotd] Update rbmotd for Review Board 4.0 This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. This also modernizes the codebase a bit, adding `unicode_literals` and docstrings. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.	fe683cffc66ac831fdac81fc14312f2c756e8428

Summary

[rbmotd] Update rbmotd for Review Board 4.0

This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. This also modernizes the codebase a bit, adding `unicode_literals` and docstrings. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.

fe683cffc66ac831fdac81fc14312f2c756e8428

Issues

Description	From	Last Updated
These should be in the same import group. While here, can you add the standard unicode_literals import?	chipx86	June 29, 2020, 2:42 p.m.
Can you add some docs while you're here? Took me a few to figure out what this was doing (with …	chipx86	June 29, 2020, 2:42 p.m.
"Board"	chipx86	June 29, 2020, 2:55 p.m.
Probably MotdExtension would be appropriate here.	chipx86	June 29, 2020, 2:55 p.m.
This would be SafeText. SafeString is bytes on Python 2.	chipx86	June 29, 2020, 2:55 p.m.
We've only been using * for JavaScript, since there's no base object. For Python, we've been using object.	chipx86	June 29, 2020, 2:55 p.m.
The module is still safestring, just the class is SafeText.	chipx86	June 30, 2020, 9:49 a.m.

flake8 passed.

JSHint passed.

rbmotd/rbmotd/admin_urls.py (Diff revision 1)

The issue has been resolved. Show all issues

These should be in the same import group.

While here, can you add the standard unicode_literals import?

rbmotd/rbmotd/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you add some docs while you're here? Took me a few to figure out what this was doing (with the self-call to set_key_value()).

Description:

		This change updates the message of the day extension for changes in
		Review Board 4.0. This includes moving away from the old `patterns`
		method for creating urlpatterns, and updating for API changes in Djblets
~		config forms.
	~	config forms. This also modernizes the codebase a bit, adding
	+	`unicode_literals` and docstrings.

Commits:

	Summary	ID
	Update rbmotd for Review Board 4.0 This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.	b7630a4652041756d7b8e184eff74b2a9348526f
	Update rbmotd for Review Board 4.0 This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. This also modernizes the codebase a bit, adding `unicode_literals` and docstrings. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.	18a1873a9c642345c345f4696b1d5b3dedf7ea61

Diff:

Revision 2 (+118 -28)

Show changes

	rbmotd/rbmotd/admin_urls.py
	rbmotd/rbmotd/extension.py
	rbmotd/rbmotd/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
Looks good. A couple small doc nits.
```
rbmotd/rbmotd/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"Board"
```
rbmotd/rbmotd/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Probably MotdExtension would be appropriate here.
```
rbmotd/rbmotd/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This would be SafeText. SafeString is bytes on Python 2.
```

rbmotd/rbmotd/forms.py (Diff revision 2)

The issue has been resolved. Show all issues

We've only been using * for JavaScript, since there's no base object. For Python, we've been using object.

Commits:

	Summary	ID
	Update rbmotd for Review Board 4.0 This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. This also modernizes the codebase a bit, adding `unicode_literals` and docstrings. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.	18a1873a9c642345c345f4696b1d5b3dedf7ea61
	[rbmotd] Update rbmotd for Review Board 4.0 This change updates the message of the day extension for changes in Review Board 4.0. This includes moving away from the old `patterns` method for creating urlpatterns, and updating for API changes in Djblets config forms. This also modernizes the codebase a bit, adding `unicode_literals` and docstrings. Testing Done: Activated and configured the motd extension. Verified that everything worked as expected.	fe683cffc66ac831fdac81fc14312f2c756e8428

Diff:

Revision 3 (+118 -28)

Show changes

	rbmotd/rbmotd/admin_urls.py
	rbmotd/rbmotd/extension.py
	rbmotd/rbmotd/forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbmotd/rbmotd/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
The module is still safestring, just the class is SafeText.
```

Status:: Completed
Change Summary:: Pushed to master (abe61a6)