Improve reliability and use of feature flag testing.

Review Request #11054 — Created June 24, 2020 and submitted

chipx86
Djblets
release-1.0.x
djblets

override_feature_check() and override_feature_checks() weren't
properly cleaning up after a crash or assertion, causing a feature flag
to stay to stay modified after use, potentially disrupting other tests.

This change fixes that by ensuring we clear the state in a finally
clause.

It also improves these methods by allowing a Feature instance to be
passed instead of just its ID, which simplifies usage.

Unit tests pass.

Summary
Improve reliability and use of feature flag testing.
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (c8dcafb)
Loading...