flake8
passed.
JSHint
passed.
Review Request #11054 — Created June 24, 2020 and submitted
override_feature_check()
andoverride_feature_checks()
weren't
properly cleaning up after a crash or assertion, causing a feature flag
to stay to stay modified after use, potentially disrupting other tests.This change fixes that by ensuring we clear the state in a
finally
clause.It also improves these methods by allowing a
Feature
instance to be
passed instead of just its ID, which simplifies usage.
Unit tests pass.
Summary | ID |
---|---|
0bbdbecce239e8b55be482b9d9b0bbe7ffd0a542 |