Fix a crash on Permission Denied in the Review General Comment API.

Review Request #11052 — Created June 22, 2020 and submitted

Information

Review Board
release-3.0.x

Reviewers

When trying to POST to the Review General Comment API without permission
to modify the review, the API would pass to the wrong variable to
get_no_access_error(), causing an HTTP 500.

This is a simple change that fixes the variable and adds a unit test to
ensure the fix does not regress.

Unit tests pass.

Summary ID
Fix a crash on Permission Denied in the Review General Comment API.
When trying to POST to the Review General Comment API without permission to modify the review, the API would pass to the wrong variable to `get_no_access_error()`, causing an HTTP 500. This is a simple change that fixes the variable and adds a unit test to ensure the fix does not regress.
a2d62fe9955585a7232a1af912cc971780a927b3
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (4bea43b)
Loading...