Summary

Fix a crash on Permission Denied in the Review General Comment API.

Review Request #11052 — Created June 22, 2020 and submitted June 23, 2020, 11:21 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

4850

Depends On

Reviewers

Groups

reviewboard

People

Description

When trying to POST to the Review General Comment API without permission
to modify the review, the API would pass to the wrong variable to
get_no_access_error(), causing an HTTP 500.

This is a simple change that fixes the variable and adds a unit test to
ensure the fix does not regress.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix a crash on Permission Denied in the Review General Comment API. When trying to POST to the Review General Comment API without permission to modify the review, the API would pass to the wrong variable to `get_no_access_error()`, causing an HTTP 500. This is a simple change that fixes the variable and adds a unit test to ensure the fix does not regress.	a2d62fe9955585a7232a1af912cc971780a927b3

flake8 passed.

JSHint passed.

Bugs:: 4850

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (4bea43b)