Update all model registrations to use the new AdminSite and ModelAdmin.

Review Request #11039 — Created May 27, 2020 and updated

chipx86
Review Board
release-4.0.x
reviewboard

With the introduction of new AdminSite and ModelAdmin classes for
our new administration UI, it's important that we set a precedent of
using these new classes for all model registration, even though the new
versions are compatible with the old ones.

This change switches all model registration to use our new AdminSite
explicitly, and switches all ModelAdmin subclasses to use our new base
class.

Unit tests pass.

Verified that these were registered correctly in the admin UI.

Summary
Update all model registrations to use the new AdminSite and ModelAdmin.
Description From Last Updated

In your description, should "set a precedence" be "set a precedent"?

daviddavid

E305 expected 2 blank lines after class or function definition, found 1

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. In your description, should "set a precedence" be "set a precedent"?

  3. 
      
chipx86
Review request changed

Change Summary:

  • Fixed a missing blank line.
  • Fixed a typo in the description.

Description:

   

With the introduction of new AdminSite and ModelAdmin classes for

~   our new administration UI, it's important that we set a precedence of
  ~ our new administration UI, it's important that we set a precedent of
    using these new classes for all model registration, even though the new
    versions are compatible with the old ones.

   
   

This change switches all model registration to use our new AdminSite

    explicitly, and switches all ModelAdmin subclasses to use our new base
    class.

Commits:

Summary
-
Update all model registrations to use the new AdminSite and ModelAdmin.
+
Update all model registrations to use the new AdminSite and ModelAdmin.

Diff:

Revision 2 (+144 -146)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
Loading...