Summary

Update all model registrations to use the new AdminSite and ModelAdmin.

Review Request #11039 — Created May 27, 2020 and submitted Aug. 30, 2020, 5:16 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

With the introduction of new AdminSite and ModelAdmin classes for
our new administration UI, it's important that we set a precedent of
using these new classes for all model registration, even though the new
versions are compatible with the old ones.

This change switches all model registration to use our new AdminSite
explicitly, and switches all ModelAdmin subclasses to use our new base
class.

Testing Done

Unit tests pass.

Verified that these were registered correctly in the admin UI.

Commits

Summary	ID
Update all model registrations to use the new AdminSite and ModelAdmin. With the introduction of new `AdminSite` and `ModelAdmin` classes for our new administration UI, it's important that we set a precedent of using these new classes for all model registration, even though the new versions are compatible with the old ones. This change switches all model registration to use our new `AdminSite` explicitly, and switches all `ModelAdmin` subclasses to use our new base class.	384be35b6713e5d3a5e1a11a38f843258075851d

Summary

Update all model registrations to use the new AdminSite and ModelAdmin.

With the introduction of new `AdminSite` and `ModelAdmin` classes for our new administration UI, it's important that we set a precedent of using these new classes for all model registration, even though the new versions are compatible with the old ones. This change switches all model registration to use our new `AdminSite` explicitly, and switches all `ModelAdmin` subclasses to use our new base class.

384be35b6713e5d3a5e1a11a38f843258075851d

Issues

Description	From	Last Updated
In your description, should "set a precedence" be "set a precedent"?	david	June 16, 2020, 6:04 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	June 16, 2020, 6:04 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/site/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E305 expected 2 blank lines after class or function definition, found 1
```

The issue has been resolved. Show all issues

In your description, should "set a precedence" be "set a precedent"?

Change Summary:


Fixed a missing blank line.
Fixed a typo in the description.

Description:

		With the introduction of new `AdminSite` and `ModelAdmin` classes for
~		our new administration UI, it's important that we set a precedence of
	~	our new administration UI, it's important that we set a precedent of
		using these new classes for all model registration, even though the new
		versions are compatible with the old ones.

		This change switches all model registration to use our new `AdminSite`
		explicitly, and switches all `ModelAdmin` subclasses to use our new base
		class.

Commits:

	Summary	ID
	Update all model registrations to use the new AdminSite and ModelAdmin. With the introduction of new `AdminSite` and `ModelAdmin` classes for our new administration UI, it's important that we set a precedence of using these new classes for all model registration, even though the new versions are compatible with the old ones. This change switches all model registration to use our new `AdminSite` explicitly, and switches all `ModelAdmin` subclasses to use our new base class.	01eb7561456566a0e4221ad9f24225108999d5b1
	Update all model registrations to use the new AdminSite and ModelAdmin. With the introduction of new `AdminSite` and `ModelAdmin` classes for our new administration UI, it's important that we set a precedent of using these new classes for all model registration, even though the new versions are compatible with the old ones. This change switches all model registration to use our new `AdminSite` explicitly, and switches all `ModelAdmin` subclasses to use our new base class.	384be35b6713e5d3a5e1a11a38f843258075851d

Diff:

Revision 2 (+144 -146)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/attachments/admin.py
	reviewboard/changedescs/admin.py
	reviewboard/diffviewer/admin.py
	reviewboard/hostingsvcs/admin.py
	reviewboard/integrations/admin.py
	reviewboard/notifications/admin.py
	reviewboard/oauth/admin.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (433889e)

reviewboard/site/admin.py (Diff revision 1)