• 
      

    Add support for a reviewboard.repository_name counter in Perforce.

    Review Request #11030 — Created May 19, 2020 and submitted

    Information

    RBTools
    release-2.0.x
    0f7121b...

    Reviewers

    Historically, we've provided support for specifying a Review Board
    server URL as a Perforce counter key/value, useful for very large
    deployments that don't want to juggle .reviewboardrc files. This has
    still left RBTools to scan for repositories, comparing paths, which is
    slow.

    This change introduces some base level support for SCMClients to
    provide a repository name as part of the RepositoryInfo, which will be
    used as a fallback if an explicit repository name is not specified
    during repository and review request lookup.

    For the Perforce side, a new reviewboard.repository_name counter is
    now supported, which provides the value for this new field.

    While we still recommend a .reviewboardrc for deployments, this should
    help RBTools work faster and more reliably with very large, old,
    established Perforce repositories.

    Unit tests pass.

    Set the counter in a test repository and verified Review Board was trying
    to use it for posting changes and displaying status.

    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (f0ce1b8)