Fix up the integrations pages for modern Django and Djblets changes.

Review Request #11013 — Created May 7, 2020 and submitted

chipx86
Djblets
release-2.0.x
djblets

This makes a handful of changes to the Admin UI for managing
integrations, fixing up some interactions, and leveraging new work in
the Djblets Config Forms UI.

The main integrations configuration template has changed to hard-code
fewer things (making it easier to integrate into the Review Board admin
UI), moving down some of the Django-specific parts into Djblets's base
admin UI template. Some state has also been injected into the template
from the view, providing information necessary for both Django and
Review Board to properly render the Save/Delete buttons for the page
(and

The JavaScript backing the integrations list now makes use of the new
state management and display code for Config Forms list items. This
reduces the work that the template must do, and gets rid of some
now-unnecessary CSS.

It also fixes some display issues with modalbox usage when confirming
deletion of an integration configuration.

All Python and JavaScript unit tests pass.

Manually tested the saving and deletion functionality for an integration
configuration on the configuration page and deletion on the integration
list page.

Summary
Fix up the integrations pages for modern Django and Djblets changes.
Description From Last Updated

E999 SyntaxError: invalid syntax

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (82af0d9)
Loading...