Add a search field to the repository resource.

Review Request #10997 — Created April 10, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

The new repository selector UI was using a nonexistant q field to
query the repository API. This often appeared to work correctly because
the selector would end up getting the first page of results, and then
selectize would do the filtering on the client side. If the repository
the user wanted wasn't in the first page of results, they wouldn't be
able to get to it.

While the API does have a name field, that field tests for equivalence
rather than being a search term like the q fields that are part of the
user and group APIs. This change adds a matching q field to the
repository API which does an istartswith query on the name.

  • Interacted with the related repository selector widget and checked the
    responses in the network tab.
  • Ran unit tests.
Summary ID
Add a search field to the repository resource.
The new repository selector UI was using a nonexistant `q` field to query the repository API. This often appeared to work correctly because the selector would end up getting the first page of results, and then selectize would do the filtering on the client side. If the repository the user wanted wasn't in the first page of results, they wouldn't be able to get to it. While the API does have a `name` field, that field tests for equivalence rather than being a search term like the `q` fields that are part of the user and group APIs. This change adds a matching `q` field to the repository API which does an istartswith query on the name. Testing Done: Interacted with the related repository selector widget and checked the responses in the network tab.
3e2f03ba38da5c236326bc4ec35e1dd3828f05c3
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (c66a460)
Loading...