flake8
passed.
JSHint
passed.
Review Request #10992 — Created April 7, 2020 and submitted
This change makes the modal box focusable by adding the
attributetabindex="0"
to the element and calling focus on it
when it is initialized. This allows views that havemodalBox
as a parent to detect key events within it, such asRB.DialogView
.
Manual verification that the modal box is focused when it is
created in the new review request dialog and the file upload
dialog. This is indicated by the focus ring around the dialogs
in the attached screenshots.