Don't use `git checkout --unshallow` for full-repo Travis CI builds.
Review Request #10974 — Created March 26, 2020 and submitted
Information | |
---|---|
david | |
rbintegrations | |
release-1.0.x | |
b974db8... | |
Reviewers | |
rbintegrations | |
Some people use
git: depth: False
in thier Travis CI config, most
commonly because tests may need full access to the repository history.
In this case, we were still includinggit checkout --unshallow
in the
build script, which wasn't fatal but produced ugly warnings. This change
checks for a full-repo checkout in the Travis config and only adds the
checkout if necessary.
Created a Travis integration that included
git: depth: False
in the
config. Saw that prior to this change, an ugly error was shown in the
build log, and after everything was fine.
Description | From | Last Updated |
---|---|---|
Typo in the description: "thier" -> "their". |
|
|
Can you also add unit tests for this? |
|
|
F811 redefinition of unused 'test_build_new_review_request' from line 117 |
![]() |
|
This would be nicer with a new string after every \n, just to help with readability. |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+57 -4) |
Checks run (1 failed, 1 succeeded)
flake8
-
rbintegrations/travisci/tests.py (Diff revision 2) F811 redefinition of unused 'test_build_new_review_request' from line 117
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+57 -4) |
Checks run (2 succeeded)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+57 -4) |
Checks run (2 succeeded)
-
-
rbintegrations/travisci/tests.py (Diff revision 4) This would be nicer with a new string after every
\n
, just to help with readability.