• 
      

    Don't use `git checkout --unshallow` for full-repo Travis CI builds.

    Review Request #10974 — Created March 26, 2020 and submitted

    Information

    rbintegrations
    release-1.0.x
    b974db8...

    Reviewers

    Some people use git: depth: False in thier Travis CI config, most
    commonly because tests may need full access to the repository history.
    In this case, we were still including git checkout --unshallow in the
    build script, which wasn't fatal but produced ugly warnings. This change
    checks for a full-repo checkout in the Travis config and only adds the
    checkout if necessary.

    Created a Travis integration that included git: depth: False in the
    config. Saw that prior to this change, an ugly error was shown in the
    build log, and after everything was fine.

    Description From Last Updated

    Typo in the description: "thier" -> "their".

    chipx86chipx86

    Can you also add unit tests for this?

    chipx86chipx86

    F811 redefinition of unused 'test_build_new_review_request' from line 117

    reviewbotreviewbot

    This would be nicer with a new string after every \n, just to help with readability.

    chipx86chipx86
    chipx86
    1. 
        
    2. Show all issues

      Typo in the description: "thier" -> "their".

    3. 
        
    chipx86
    1. 
        
    2. Show all issues

      Can you also add unit tests for this?

    3. 
        
    david
    Review request changed
    Commit:
    a385c9f6d2acdfd7fda814b2c3d661a517779c0a
    1e42d3637d8837a8a47abc3481e06a6b441a4a1e

    Checks run (1 failed, 1 succeeded)

    flake8 failed.
    JSHint passed.

    flake8

    david
    david
    chipx86
    1. 
        
    2. rbintegrations/travisci/tests.py (Diff revision 4)
       
       
       
      Show all issues

      This would be nicer with a new string after every \n, just to help with readability.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (f89757a)