• 
      

    Include parent diffs in Travis CI job payload.

    Review Request #10973 — Created March 26, 2020 and submitted

    Information

    rbintegrations
    release-1.0.x
    0095cc1...

    Reviewers

    The Travis CI implementation wasn't serializing parent diffs into the
    job payload. This sometimes resulted in builds which would wait and
    eventually time out as it tried to apply a patch that didn't work
    and waited for user input (why patch thinks it's on a tty is beyond me).

    This change adds serialization of the parent diff, if necessary. We
    don't have any facilities for doing this easily, so it basically
    replicates the logic that exists for normal diffs.

    Triggered successful Travis CI builds for changes that had parent diffs,
    and verified that changes without parent diffs were unaffected.

    Description From Last Updated

    Can you also add unit tests for this?

    chipx86chipx86

    Kinda want to recommend we use select_related(...) here to get only the fields we need, but really, we're going to …

    chipx86chipx86
    chipx86
    1. 
        
    2. rbintegrations/travisci/integration.py (Diff revision 1)
       
       
      Show all issues

      Kinda want to recommend we use select_related(...) here to get only the fields we need, but really, we're going to want to just do this correctly over in Review Board. Can you add a task for that and assign it to me?

      Also, we should use filediff instead of file to avoid the reserved word.

    3. 
        
    chipx86
    1. 
        
    2. Show all issues

      Can you also add unit tests for this?

    3. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (8a288c9)