Include parent diffs in Travis CI job payload.
Review Request #10973 — Created March 26, 2020 and submitted
The Travis CI implementation wasn't serializing parent diffs into the
job payload. This sometimes resulted in builds which would wait and
eventually time out as it tried to apply a patch that didn't work
and waited for user input (why patch thinks it's on a tty is beyond me).
This change adds serialization of the parent diff, if necessary. We
don't have any facilities for doing this easily, so it basically
replicates the logic that exists for normal diffs.
Triggered successful Travis CI builds for changes that had parent diffs,
and verified that changes without parent diffs were unaffected.
rbintegrations/travisci/integration.py (Diff revision 1)
Kinda want to recommend we use
select_related(...)here to get only the fields we need, but really, we're going to want to just do this correctly over in Review Board. Can you add a task for that and assign it to me?
Also, we should use
fileto avoid the reserved word.
Revision 2 (+95 -5)
Checks run (2 succeeded)