Summary

Update for changes in Travis CI's webhook payload format.

Review Request #10970 — Created March 26, 2020 and submitted April 9, 2020, 10:49 a.m.

Information

Owner

david

Repository

rbintegrations

Branch

release-1.0.x

Bugs

Depends On

Commit

9ab860b...

Reviewers

Groups

rbintegrations

People

Description

Travis CI has made some changes to their webhook payload. These are
currently effective on travis-ci.com, and will likely be making it to
travis-ci.org soon.

The biggest of these is that the global_env key is completely gone.
There's a top-level env key, but that's in a weird hard-to-parse
format. I've changed it to pull the relevant keys out of the matrix data
instead.

Second, I was encountering a new errored state for some builds. I've
added handling for this and logging for any future states which we don't
handle.

Testing Done

Posted some changes that triggered Travis CI builds and saw the webhook
handler work correctly.

Issues

Description	From	Last Updated
Can you add unit tests for the configuration parsing, errors around it, and the error states?	chipx86	April 7, 2020, 2:25 p.m.
Can we also end up with an IndexError due to the [0]?	chipx86	April 7, 2020, 9:46 a.m.
It'd be nice to have something in here to reference maybe the build, or configuration, or something. Otherwise we have …	chipx86	April 7, 2020, 9:50 a.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2020, 2:28 p.m.
F811 redefinition of unused 'test_webhook_bad_integration_config' from line 371	reviewbot	April 7, 2020, 2:28 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2020, 2:28 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you add unit tests for the configuration parsing, errors around it, and the error states?

rbintegrations/travisci/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we also end up with an IndexError due to the [0]?
```

rbintegrations/travisci/views.py (Diff revision 1)

The issue has been resolved. Show all issues

It'd be nice to have something in here to reference maybe the build, or configuration, or something. Otherwise we have little to go off of for reproducing.

Change Summary:

Add unit tests.

Commit:

-	edc37a20a9e366de882005f5529108b0bf5037e7
+	0c1762ed4710a734a5ee5dd3b66b7a0eca12398d

Diff:

Revision 2 (+387 -109)

Show changes

	rbintegrations/travisci/tests.py
	rbintegrations/travisci/views.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbintegrations/travisci/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbintegrations/travisci/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_webhook_bad_integration_config' from line 371
```
rbintegrations/travisci/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commit:

-	0c1762ed4710a734a5ee5dd3b66b7a0eca12398d
+	9ab860b537d62a2c431d2d9c20f41afaccd1068a

Diff:

Revision 3 (+361 -110)

Show changes

	rbintegrations/travisci/tests.py
	rbintegrations/travisci/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.0.x (6db9ab3)