Summary

Fix build-i18n.py to set up the appropriate environment before importing.

Review Request #10944 — Created March 9, 2020 and submitted March 12, 2020, 6:58 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

build-i18n.py, which is a necessary part of the package build process,

was assuming it had the right version of Review Board and Django in the

import path when it began importing modules. While this is often going

to be the case when building packages, it's not necessarily the case in

CI.
Our build-media.py script has code to set up the correct environment

before doing imports, so it was able to work fine in CI. This change

simply copies over that logic to build-i18n.py.

Testing Done

Built the package successfully.

Commits

Summary	ID
Fix build-i18n.py to set up the appropriate environment before importing. `build-i18n.py`, which is a necessary part of the package build process, was assuming it had the right version of Review Board and Django in the import path when it began importing modules. While this is often going to be the case when building packages, it's not necessarily the case in CI. Our `build-media.py` script has code to set up the correct environment before doing imports, so it was able to work fine in CI. This change simply copies over that logic to `build-i18n.py`.	82d747564dedf90293a6895aed1672eaecdc4c8b

Summary

Fix build-i18n.py to set up the appropriate environment before importing.

`build-i18n.py`, which is a necessary part of the package build process, was assuming it had the right version of Review Board and Django in the import path when it began importing modules. While this is often going to be the case when building packages, it's not necessarily the case in CI. Our `build-media.py` script has code to set up the correct environment before doing imports, so it was able to work fine in CI. This change simply copies over that logic to `build-i18n.py`.

82d747564dedf90293a6895aed1672eaecdc4c8b

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	March 9, 2020, 4:54 p.m.
E402 module level import not at top of file	reviewbot	March 9, 2020, 4:54 p.m.
E402 module level import not at top of file	reviewbot	March 9, 2020, 4:54 p.m.
F401 'pkg_resources' imported but unused	reviewbot	March 9, 2020, 4:54 p.m.

flake8 failed.

JSHint passed.

flake8

contrib/internal/build-i18n.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
contrib/internal/build-i18n.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
contrib/internal/build-i18n.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
contrib/internal/build-i18n.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'pkg_resources' imported but unused
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (a11c896)