flake8
-
reviewboard/reviews/models/review_request_draft.py (Diff revision 1) Show all issues
Review Request #10928 — Created Feb. 29, 2020 and updated
Information | |
---|---|
bui1 | |
Review Board | |
master | |
Reviewers | |
reviewboard | |
The review request page when the user creates a new draft to publish their changes
is empty at first unless some fields have been populated by RB Tools such as
the commit summary and description. However, not always these fields are populated
and the user is subjected to a mostly empty page. This can be a confusing user
experience where one may not know which fields are required to post a change,
what kind of content is needed for the different inputs, and where to add new files
to the request. These changes will help clarify the user experience on this page
to make it more friendly, and easier to understand what changes are needed to make
on this request before posting their work.These changes include,
- The addition of a edit icon to the file attachment area and to make it render by
default on review request drafts
- Creating a file attachment box area where users can click a button or drag and
drop a file into, making it easier to figure out where/how to add files to a request
- Changing the banner to include a checkbox group that holds all the required fields
that need to be filled out before posting a change
- Disabling the publish button until all the required checkboxes have been checked off
- Randomizing of placeholder texts from the Python backend
- Rendering of placeholder texts on various configured review request fields so the
user can understand what kind of input they need to make into a fieldRefer to the screenshot (version 2) for what it looks like so far.
Manual Tests
- Using rbt post, check if the review request page renders properly with the
placeholder text, checkbox banner group, and file attachment areas shown
- Using the new review request page, check the same above scenario
- Placeholder text is rendered with a gray font color if the page is editable
by the user and if there is no previously saved value
- If there is a previously saved value, it renders with the blank font color
- Checkbox group in the draft banner has all the required fields from the
review request page
- Publish button stays disabled until the user has checked off all the required
check boxes
- Publish button renders disabled at first even when the page first renders if the
review request is not public yet and if the request is being edited on first save
- Placeholder text is randomly being changed from the python backend
- Placeholder text is being rendered if there is no previously saved value
- File attachment area is shown be default if the request is editable
- File attachment area is responsive on mobile even after adding/deleting files
- File attachment area is hidden if the request is not editable and if no files
exist for the review request
- All fields are keyboard accessibleUnit Tests
- Publish button is disabled when all required checkboxes are not checked off
- Publish button is enabled when all required checkboxes are checked off or
there are no required fields in the page
- File attachment area is shown by default if the review request is editable
- File attachment area is hidden if there are no attachments and the review
request is non-editable
- Python backend returns the proper required fields from RB default settings
- Placeholder text is rendered if there is no previously saved text
- Placeholder text is not rendered if there is previously saved text
Summary | Author |
---|---|
bui1@ualberta.ca |
Description | From | Last Updated |
---|---|---|
I think the placeholder for new items should go at the end of the list. This is where new items … |
|
|
There's some hilarious irony in these placeholders recommending limiting to 50 characters and wrapping to 72, then blasting past those … |
|
|
E501 line too long (93 > 79 characters) |
![]() |
|
E501 line too long (93 > 79 characters) |
![]() |
|
E501 line too long (84 > 79 characters) |
![]() |
|
E501 line too long (93 > 79 characters) |
![]() |
|
E114 indentation is not a multiple of four (comment) |
![]() |
|
E501 line too long (84 > 79 characters) |
![]() |
|
E501 line too long (93 > 79 characters) |
![]() |
|
E114 indentation is not a multiple of four (comment) |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E501 line too long (80 > 79 characters) |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E502 the backslash is redundant between brackets |
![]() |
|
E501 line too long (83 > 79 characters) |
![]() |
|
E501 line too long (80 > 79 characters) |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E127 continuation line over-indented for visual indent |
![]() |
|
E999 SyntaxError: invalid syntax |
![]() |
|
E113 unexpected indentation |
![]() |
|
E113 unexpected indentation |
![]() |
|
can we use BEM for the class name? |
|
|
is it possible to use one of the greys from reviewboard/static/rb/css/ui/colors.less ? |
|
|
i think this class should follow the BEM naming conventions and maybe be clearer about what it's used for eg. … |
|
|
from the screenshot, the container looks about the same size as the thumbnails and might share some of the same … |
|
|
i think we should be using BEM here for the class names too |
|
|
i think the padding should use variables like in reviewboard/static/rb/css/ui/page-sidebar.less |
|
|
missing documentation for this function |
|
|
missing documentation |
|
|
getting the element by appending the target value to the id selector and using jQuery to search for that feels … |
|
|
What about discarding "Fill out the" in the label? It seems kinda repetitive when every item in the list has … |
![]() |
|
should value be "Click to browse"? (ie. first letter capitalized) |
|
|
i think this would be better named as this._$editButton because it can be clicked and its role is button |
|
|
i think this could just be called this._$editIcon since it's actually referring to the icon |
|
|
from the other variables defined before this one, i think the id should be suffixed with -action to be consistent |
|
|
i think this.$el.removeClass('placeholder-text') would be clearer |
|
|
i think this.$el.addClass('placeholder-text') would be clearer |
|
|
this.$el.removeClass('placeholder-text') |
|
|
this.$el.addClass('placeholder-text') |
|
|
We generally want to use parens for wrapping long things rather than continuation characters: base_placeholder_text = ( '... ' '... … |
|
|
Parens instead of \ |
|
|
Parens here too. |
|
|
We use the name "Base" to indicate that the class will be inherited from. In this case I think "ReviewRequestFieldRequirements" … |
|
|
This should have a trailing comma at the end. Please also keep the keys in alphabetical order. |
|
|
Please put this blank line back. |
|
|
Should have two blank lines on either side of the top-level block. |
|
|
Add a blank line here, please. |
|
|
Since we're changing this, let's take the opportunity to move these to the new colors definitions. @file-attachment-bg: #rb-ns-ui.colors[@white]; @file-attachment-overlay-bg: #rb-ns-ui.colors[@grey-90]; … |
|
|
Don't need to add this line. |
|
|
This should be in the imperative mood rather than passive ("Change the publish..." instead of "Changes") |
|
|
Please wrap this line to 80 columns. |
|
|
Please add a blank line between these two. We also like to make sure any jQuery-type variable starts with $, … |
|
|
Please use single-quotes instead of double. |
|
|
This can be a one-liner, and we can also use jQuery's eq method to simplify the selector: this.$buttons.eq(0).prop( 'disabled', this.requiredCheckboxes.length … |
|
|
There are a few things in here. First, since we're in ES6, we can use template strings (note the backticks). … |
|
|
This line can just be this._changePublishButtonState() |
|
|
In ES6 files, we have a much better way of formatting text like this: this._$attachments.prepend(dedent` <div class="rb-c-file-upload-container"> <div> <p>Drop file … |
|
|
In jQuery calls when creating a new (single) element, you don't need the closing tag. |
|
|
Wrap to 80 columns please. |
|
|
Wrap to 80 columns. |
|
|
Add a blank line in here. |
|
|
Wrap to 80 columns. |
|
|
Add a blank line in here. |
|
|
Wrap to 80 columns. |
|
|
Perhaps I'm reading this wrong, but won't this actually write the placeholder text to the database? Don't we want to … |
|
|
E302 expected 2 blank lines, found 1 |
![]() |
|
W292 no newline at end of file |
![]() |
|
E303 too many blank lines (2) |
![]() |
|
E303 too many blank lines (2) |
![]() |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+140 -32) |
reviewboard/reviews/models/review_request_draft.py (Diff revision 2) |
---|
E501 line too long (93 > 79 characters)
Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+402 -44) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Added Files: |
reviewboard/reviews/models/review_request_draft.py (Diff revision 3) |
---|
E501 line too long (93 > 79 characters)
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 3) |
---|
E114 indentation is not a multiple of four (comment)
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+424 -54) |
reviewboard/reviews/models/review_request_draft.py (Diff revision 4) |
---|
E501 line too long (93 > 79 characters)
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 4) |
---|
E114 indentation is not a multiple of four (comment)
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 5 (+484 -52) |
|||||||||||||||||||||||||||||||||||||||||||||
Removed Files: |
||||||||||||||||||||||||||||||||||||||||||||||
Added Files: |
reviewboard/reviews/builtin_fields.py (Diff revision 5) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 5) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 5) |
---|
E502 the backslash is redundant between brackets
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 6 (+496 -54) |
reviewboard/reviews/builtin_fields.py (Diff revision 6) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 6) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 6) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 6) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 6) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6) |
---|
E501 line too long (80 > 79 characters)
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 7 (+492 -40) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Removed Files: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Added Files: |
reviewboard/reviews/builtin_fields.py (Diff revision 7) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 7) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 7) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 7) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/builtin_fields.py (Diff revision 7) |
---|
E502 the backslash is redundant between brackets
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 7) |
---|
E501 line too long (80 > 79 characters)
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 8 (+498 -40) |
reviewboard/reviews/builtin_fields.py (Diff revision 8) |
---|
E127 continuation line over-indented for visual indent
reviewboard/reviews/builtin_fields.py (Diff revision 8) |
---|
E127 continuation line over-indented for visual indent
Description: |
|
---|
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 9 (+502 -40) |
reviewboard/reviews/builtin_fields.py (Diff revision 9) |
---|
E127 continuation line over-indented for visual indent
reviewboard/reviews/builtin_fields.py (Diff revision 9) |
---|
E127 continuation line over-indented for visual indent
reviewboard/reviews/builtin_fields.py (Diff revision 9) |
---|
E127 continuation line over-indented for visual indent
reviewboard/reviews/builtin_fields.py (Diff revision 9) |
---|
E127 continuation line over-indented for visual indent
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 10 (+498 -40) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 11 (+498 -40) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 12 (+498 -34) |
This looks solid to me! Good work! Only one suggestion on the check box label.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
What about discarding "Fill out the" in the label? It seems kinda repetitive when every item in the list has this text.
looking good! i think it would be nice to have a more complete screenshot (ie. without cutting off the top navigation bar) so we can get the full effect of the new banner, especially because it adds so much vertical space
reviewboard/static/rb/css/pages/reviews.less (Diff revision 12) |
---|
is it possible to use one of the greys from
reviewboard/static/rb/css/ui/colors.less
?
reviewboard/static/rb/css/pages/reviews.less (Diff revision 12) |
---|
i think this class should follow the BEM naming conventions and maybe be clearer about what it's used for eg.
rb-c-file-upload-container
-file-area-container
made me think that it's just used for showing a file or something like that
reviewboard/static/rb/css/pages/reviews.less (Diff revision 12) |
---|
from the screenshot, the container looks about the same size as the thumbnails and might share some of the same properties right? are there constants defined for any of these properties that we can use?
reviewboard/static/rb/css/ui/banners.less (Diff revision 12) |
---|
i think we should be using BEM here for the class names too
reviewboard/static/rb/css/ui/banners.less (Diff revision 12) |
---|
i think the padding should use variables like in
reviewboard/static/rb/css/ui/page-sidebar.less
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
missing documentation for this function
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
missing documentation
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
getting the element by appending the target value to the id selector and using jQuery to search for that feels kind of hacky - is it not possible to get the element from the event itself?
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
should value be
"Click to browse"
? (ie. first letter capitalized)
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
i think this would be better named as
this._$editButton
because it can be clicked and its role is button
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
i think this could just be called
this._$editIcon
since it's actually referring to the icon
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 12) |
---|
from the other variables defined before this one, i think the id should be suffixed with
-action
to be consistent
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 12) |
---|
i think
this.$el.removeClass('placeholder-text')
would be clearer
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 12) |
---|
i think
this.$el.addClass('placeholder-text')
would be clearer
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 12) |
---|
this.$el.removeClass('placeholder-text')
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 12) |
---|
this.$el.addClass('placeholder-text')
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 13 (+970 -454) |
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 14 (+1140 -476) |
I think the placeholder for new items should go at the end of the list. This is where new items show up, so it's like you're "filling in" the dashed box with the thing you're uploading.
There's some hilarious irony in these placeholders recommending limiting to 50 characters and wrapping to 72, then blasting past those limits.
Rather than suggesting those in the text (while we think they're good ideas, and enforce them for our stuff, not everyone does), let's just show by example what good lengths are.
reviewboard/reviews/builtin_fields.py (Diff revision 14) |
---|
We generally want to use parens for wrapping long things rather than continuation characters:
base_placeholder_text = ( '... ' '... ' '...')
reviewboard/reviews/builtin_fields.py (Diff revision 14) |
---|
This use of a continuation character is correct, though.
reviewboard/reviews/fields.py (Diff revision 14) |
---|
We use the name "Base" to indicate that the class will be inherited from. In this case I think "ReviewRequestFieldRequirements" might be more appropriate.
But I don't think we even need a new class for this--this isn't Java. A function (
get_review_request_required_fields
, maybe?) would be better.Will need a docstring whichever way you go.
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 14) |
---|
This should have a trailing comma at the end. Please also keep the keys in alphabetical order.
reviewboard/static/rb/css/pages/reviews.less (Diff revision 14) |
---|
Should have two blank lines on either side of the top-level block.
reviewboard/static/rb/css/pages/reviews.less (Diff revision 14) |
---|
Since we're changing this, let's take the opportunity to move these to the new colors definitions.
@file-attachment-bg: #rb-ns-ui.colors[@white]; @file-attachment-overlay-bg: #rb-ns-ui.colors[@grey-90]; @file-attachment-overlay-border-color: #rb-ns-ui.colors[@grey-80]; ... @file-attachment-border-color: #rb-ns-ui.colors[@grey-60];
reviewboard/static/rb/js/pages/models/reviewablePageModel.es6.js (Diff revision 14) |
---|
Don't need to add this line.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
This should be in the imperative mood rather than passive ("Change the publish..." instead of "Changes")
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
Please wrap this line to 80 columns.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
Please add a blank line between these two.
We also like to make sure any jQuery-type variable starts with $, so
$checkbox
for the name.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
Please use single-quotes instead of double.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
This can be a one-liner, and we can also use jQuery's
eq
method to simplify the selector:this.$buttons.eq(0).prop( 'disabled', this.requiredCheckboxes.length !== this.numberOfBoxesChecked);
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
There are a few things in here.
First, since we're in ES6, we can use template strings (note the backticks).
We should also not use the name "class", since it's a reserved word.
Finally, anything inside a call to
gettext
must be a literal. It can't be computed due to the way the gettext scanner works. Fortunately, there's a formatter we can use:id: `${fieldName}-banner-checkbox`, className: 'banner-checkbox', label: interpolate(gettext('Fill out the %s field'), [fieldName]),
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
This line can just be
this._changePublishButtonState()
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
In ES6 files, we have a much better way of formatting text like this:
this._$attachments.prepend(dedent` <div class="rb-c-file-upload-container"> <div> <p>Drop file attachments here</p> <p>or</p> <input type="button" id="select-file-for-review-action" value="Click to browse"> </div> </div> `);
That said, we should probably also wrap this in
_.template
and pass all the user-visible text in as variables that are wrapped ingettext()
to enable localization of this UI.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
In jQuery calls when creating a new (single) element, you don't need the closing tag.
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 14) |
---|
Wrap to 80 columns please.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Wrap to 80 columns.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Add a blank line in here.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Wrap to 80 columns.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Add a blank line in here.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Wrap to 80 columns.
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 14) |
---|
Perhaps I'm reading this wrong, but won't this actually write the placeholder text to the database? Don't we want to write an empty string instead?
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 15 (+1184 -468) |
Screen Shot 2020-03-24 at 2.01.39 PM.png: |
|
---|
Added Files: |
---|
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 16 (+1186 -468) |
Testing Done: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 17 (+1300 -468) |
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 18 (+1294 -468) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 19 (+1292 -468) |