- Download Diff

Summary:

Fix issues caused by HttpRequest API change in Python 3

Review Request #10922 — Created Feb. 26, 2020 and submitted March 24, 2020, 8:18 a.m.

Information
Owner:	david
Repository:	rbintegrations
Branch:	master
Bugs:
Depends On:
Commit:	79c65a2...
Reviewers
Groups:	rbintegrations
People:

Description

Python 3's urllib changed the request object so that instead of having a
get_data method, there's now just a data attribute. It turns out
that this attribute also existed in Python 2, although it wasn't the
official API. This change modifies the idonethis tests to use that
everywhere.

Testing Done

Ran rbintegrations unit tests.

Issues

Description	From	Last Updated
get_data() has been useless forever. It's literally just defined as return self.data, and we use .data pretty much everywhere else. …	chipx86	March 5, 2020, 12:17 a.m.
json.loads() expects a Unicode string, but request.data should be bytes. Looks like this would apply to others. Can you verify …	chipx86	March 6, 2020, 10:55 a.m.
Wanna change this to assertIsNone?	chipx86	March 6, 2020, 10:13 a.m.
And here?	chipx86	March 6, 2020, 10:13 a.m.

flake8 passed.

JSHint passed.

Show all issues

get_data() has been useless forever. It's literally just defined as return self.data, and we use .data pretty much everywhere else. Let's just move to that directly.

Description:

		Python 3's urllib changed the request object so that instead of having a
~		`get_data` method, there's now just a `data` attribute. The unit tests
~		for the idonethis integration used this API a lot, so this needed to be
~		updated to run properly on both Python 2 and 3.
	~	`get_data` method, there's now just a `data` attribute. It turns out
	~	that this attribute also existed in Python 2, although it wasn't the
	~	official API. This change modifies the idonethis tests to use that
	+	everywhere.

Commit:

-	42f03081b4813d78a7b5e9756815168b6f79523c
+	c85fdcad8e5dea27e78a501abca6e6594a5d103c

Diff:

Revision 2 (+43 -37)

Show changes

rbintegrations/idonethis/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbintegrations/idonethis/tests.py (Diff revision 2)

Show all issues

json.loads() expects a Unicode string, but request.data should be bytes.

Looks like this would apply to others. Can you verify Python 3 tests are working here?

david March 6, 2020, 10:20 a.m.

So we weren't encoding to bytes before setting Request.data (which I'll fix), but json.loads() works on both str and bytes in Python 2 and 3.

chipx86 March 6, 2020, 7:49 p.m.

Just confirmed that it's Python 3.5 that doesn't support it. Python 3.6+ will decode.

rbintegrations/idonethis/tests.py (Diff revision 2)
Show all issues
```
Wanna change this to assertIsNone?
```
rbintegrations/idonethis/tests.py (Diff revision 2)
Show all issues
```
And here?
```

Change Summary:

Use assertIsNone everywhere that it can be.

Commit:

-	c85fdcad8e5dea27e78a501abca6e6594a5d103c
+	79c65a298882306e3374aa85badb0ab95e2182df

Diff:

Revision 3 (+49 -43)

Show changes

rbintegrations/idonethis/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (4a77e38)

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

Fix issues caused by HttpRequest API change in Python 3

Description:

Commit:

Diff:

Checks run (2 succeeded)

Change Summary:

Commit:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: