Add Python version to `rbt --version` output
Review Request #10917 — Created Feb. 25, 2020 and submitted
Information | |
---|---|
xiaole2 | |
RBTools | |
master | |
Reviewers | |
rbtools | |
Add Python version to
rbt --version
output.
sys.version
has full python version value. The output is
Python 2.7.17 (default, Jan 10 2020, 00:33:00) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
and
sys.version_info
is a key=value pair tuple.
sys.version_info(major=2, minor=7, micro=17, releaselevel='final', serial=0)
and
sys.version_info[:3]
will get the first 3 keys' values into a tuple.
The output is(2, 7, 17)
To format the version for python such as x.x.x, I get each digit in the tuple.
Tested in terminal in
reviewboard-dev
virtual env andreviewboard-dev-rbt
for python 2 and 3.
andreviewboard-4.0
virtual envs andreviewboard-4.0-rbt
for python 2 and 3.Create TestCase and pass successfully using
./tests/runtests.py rbtools.commands.tests.test_main
and./tests/runtests.py rbtools.commands.tests.test_main:VersionCommandTests
. Test number is #246
Summary | Author |
---|---|
XiaoleZ | |
XiaoleZ | |
XiaoleZ | |
XiaoleZ | |
XiaoleZ |
Description | From | Last Updated |
---|---|---|
E302 expected 2 blank lines, found 1 |
![]() |
|
E221 multiple spaces before operator |
![]() |
|
E126 continuation line over-indented for hanging indent |
![]() |
|
E203 whitespace before ',' |
![]() |
|
E231 missing whitespace after ',' |
![]() |
|
W391 blank line at end of file |
![]() |

Change Summary:
Add test case for
rbt --version
command
Testing Done: |
|
|||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||||||||
Diff: |
Revision 2 (+74 -4) |
Checks run (1 failed, 1 succeeded)
flake8
-
-
-
rbtools/commands/tests/test_main.py (Diff revision 2) E126 continuation line over-indented for hanging indent
-
-
-

Change Summary:
fix python coding styling
Commits: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+80 -10) |
Checks run (2 succeeded)

-
-
rbtools/commands/tests/test_main.py (Diff revision 3) Very minor change. Would you mind removing the last comma inside the round brackets?
Otherwise, everything looks good to me.

Change Summary:
remove comma based on Katherine's feedback
Commits: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+82 -12) |