- Download Diff

Summary:

Add Python version to `rbt --version` output

Review Request #10917 — Created Feb. 25, 2020 and submitted Aug. 17, 2020, 3:05 p.m.

Information
Owner:	xiaole2
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

Add Python version to rbt --version output.
sys.version has full python version value. The output is

Python 2.7.17 (default, Jan 10 2020, 00:33:00) 
[GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
and sys.version_info is a key=value pair tuple. 

sys.version_info(major=2, minor=7,
micro=17, releaselevel='final', serial=0)
and sys.version_info[:3] will get the first 3 keys' values into a tuple. 

The output is (2, 7, 17)
To format the version for python such as x.x.x, I get each digit in the tuple.

Testing Done

Tested in terminal in reviewboard-dev virtual env and reviewboard-dev-rbt for python 2 and 3.
and reviewboard-4.0 virtual envs and reviewboard-4.0-rbt for python 2 and 3.

Create TestCase and pass successfully using ./tests/runtests.py rbtools.commands.tests.test_main and ./tests/runtests.py rbtools.commands.tests.test_main:VersionCommandTests. Test number is #246

Commits

Summary	Author
add python version	XiaoleZ
add test case	XiaoleZ
remove trailing space	XiaoleZ
python styling	XiaoleZ
remove comma	XiaoleZ

Screenshots

Files

Issues

Description	From	Last Updated
E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2020, 7:55 p.m.
E221 multiple spaces before operator	reviewbot	Feb. 25, 2020, 7:55 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Feb. 25, 2020, 7:56 p.m.
E203 whitespace before ','	reviewbot	Feb. 25, 2020, 7:56 p.m.
E231 missing whitespace after ','	reviewbot	Feb. 25, 2020, 7:56 p.m.
W391 blank line at end of file	reviewbot	Feb. 25, 2020, 7:58 p.m.

flake8 passed.

JSHint passed.

Looks good!

It would be nice to see some unit tests, especially for different python versions? You can add the tests to a test file I made called test_main.py in rbtools/commands/tests.

Change Summary:

Add test case for rbt --version command

Testing Done:

		Tested in terminal in `reviewboard-dev` virtual env and `reviewboard-dev-rbt` for python 2 and 3.
		and `reviewboard-4.0` virtual envs and `reviewboard-4.0-rbt` for python 2 and 3.
	+
	+	Create TestCase and pass successfully using `./tests/runtests.py rbtools.commands.tests.test_main` and `./tests/runtests.py rbtools.commands.tests.test_main:VersionCommandTests`. Test number is #246

Commits:

	Summary	Author
-	add python version	XiaoleZ
+	add python version	XiaoleZ
+	add test case	XiaoleZ
+	remove trailing space	XiaoleZ

Diff:

Revision 2 (+74 -4)

Show changes

	rbtools/commands/main.py
	rbtools/commands/tests/test_main.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E221 multiple spaces before operator
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E203 whitespace before ','
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/tests/test_main.py (Diff revision 2)
Show all issues
```
W391 blank line at end of file
```

Change Summary:

fix python coding styling

Commits:

	Summary	Author
-	add python version	XiaoleZ
-	add test case	XiaoleZ
-	remove trailing space	XiaoleZ
+	add python version	XiaoleZ
+	add test case	XiaoleZ
+	remove trailing space	XiaoleZ
+	python styling	XiaoleZ

Diff:

Revision 3 (+80 -10)

Show changes

	rbtools/commands/main.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/tests/test_main.py (Diff revision 3)

Very minor change. Would you mind removing the last comma inside the round brackets?

Otherwise, everything looks good to me.

Change Summary:

remove comma based on Katherine's feedback

Commits:

	Summary	Author
-	add python version	XiaoleZ
-	add test case	XiaoleZ
-	remove trailing space	XiaoleZ
-	python styling	XiaoleZ
+	add python version	XiaoleZ
+	add test case	XiaoleZ
+	remove trailing space	XiaoleZ
+	python styling	XiaoleZ
+	remove comma	XiaoleZ

Diff:

Revision 4 (+82 -12)

Show changes

	rbtools/commands/main.py
	rbtools/commands/tests/test_main.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (8194869)

You have a pending review.

Review Board 4.0 RC1 (dev)

Add Python version to `rbt --version` output

Change Summary:

Testing Done:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: