• 
      

    Preserve issue summary table filters when the table is reloaded.

    Review Request #10915 — Created Feb. 25, 2020 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    When the issue summary table is reloaded from the server, the tab and
    reviewer drop-down filters would get reset to defaults, since we were
    just replacing the old element with the new one. This could lead to
    disruption when trying to review issues while the server is loading
    content.

    The table now restores any existing state, if re-rendering or reloading
    from a new element. It won't just assume the state in the HTML is
    correct, and it won't either skip or completely override the reviewers
    filter.

    Unit tests pass.

    Manually tested reloading the issue summary table after changing filters,
    and verified the element and internal states were correct.

    Summary ID
    Preserve issue summary table filters when the table is reloaded.
    When the issue summary table is reloaded from the server, the tab and reviewer drop-down filters would get reset to defaults, since we were just replacing the old element with the new one. This could lead to disruption when trying to review issues while the server is loading content. The table now restores any existing state, if re-rendering or reloading from a new element. It won't just assume the state in the HTML is correct, and it won't either skip or completely override the reviewers filter.
    ef0bb1a9eebca3e08442c2e0c97af50bd915ad07
    Description From Last Updated

    This looks like something leftover from debugging?

    david david
    david
    1. 
        
    2. Show all issues

      This looks like something leftover from debugging?

    3. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (d4c1cac)