Add a keyboard shortcut central registry for page views.
Review Request #10913 — Created Feb. 24, 2020 and updated — Latest diff uploaded
Created an object which can be a central registry for keyboard
shortcuts on the current page. This new objectkeyBindingsis
owned byRB.Pageview. Subclasses ofRB.PageView(e.g.,diffViewerPageView
anddataGridPageViewcan extend this new object to have their own
keyboard shortcuts.Each key set can map to two things:
callbackmapping to a callback
function andhelp(temporary mapping to a str text, can be a foundation
of future features).
The old keyboard shortcuts on
diffViewerPageVieware still working.Tested on Chrome and Firefox.
Tested in
dataGridPageViewby adding this dummy code segment:... keyBindings: _.extend({ 'a': { callback: 'testAlert', } }, RB.PageView.prototype.keyBindings), testAlert() { alert("This is a test alert."); }, ...