Summary

Set owner= for KGB spies throughout rbintegrations tests.

Review Request #10911 — Created Feb. 24, 2020 and submitted March 5, 2020, 10:20 a.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Commit

c039a0a...

Reviewers

Groups

rbintegrations

People

Description

The rbintegrations tests haven't been touched in a while, and we didn't
have the new mostly-required owner= argument for spies on object
methods. This change adds those so we get less noise when running the
test suite.

Testing Done

Ran rbintegrations tests.

Issues

Description	From	Last Updated
Just a suggestion, feel free to ignore if you don't think it's worth it. I've been trying to enforce a …	chipx86	Feb. 25, 2020, 3:45 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Just a suggestion, feel free to ignore if you don't think it's worth it.

I've been trying to enforce a standard of making owner= come as the second parameter, right after the thing to spy on, just to help sort of tie them together. So:

self.spy_on(FooObject.my_func,
            owner=FooObject,
            call_fake=...)

It'd be nice to do this here, to keep it consistent with all the others, but it's just a nit.

david Feb. 25, 2020, 3:46 p.m.
```
Sure, no problem.
```

Commit:

0c9404ee44c3dfb910c7b7deef0bc97a8f591e4c

c039a0a09e032f98b3b202c960ea5f0edb6467ac

Diff:

Revision 2 (+47 -12)

Show changes

	rbintegrations/asana/tests.py
	rbintegrations/jenkinsci/tests.py
	rbintegrations/travisci/tests.py
	rbintegrations/trello/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (c354fdf)