Set owner= for KGB spies throughout rbintegrations tests.

Review Request #10911 — Created Feb. 24, 2020 and submitted

david
rbintegrations
master
c039a0a...
rbintegrations

The rbintegrations tests haven't been touched in a while, and we didn't
have the new mostly-required owner= argument for spies on object
methods. This change adds those so we get less noise when running the
test suite.

Ran rbintegrations tests.

Description From Last Updated

Just a suggestion, feel free to ignore if you don't think it's worth it. I've been trying to enforce a ...

chipx86chipx86
chipx86
  1. 
      
  2. Just a suggestion, feel free to ignore if you don't think it's worth it.

    I've been trying to enforce a standard of making owner= come as the second parameter, right after the thing to spy on, just to help sort of tie them together. So:

    self.spy_on(FooObject.my_func,
                owner=FooObject,
                call_fake=...)
    

    It'd be nice to do this here, to keep it consistent with all the others, but it's just a nit.

    1. Sure, no problem.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c354fdf)
Loading...