Summary

Scale back changes to rbext a bit.

Review Request #10908 — Created Feb. 19, 2020 and submitted March 6, 2020, 6:30 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

ca3f297...

Reviewers

Groups

reviewboard

People

Description

I had made some changes to the rbext tool to completely initialize
Review Board, but this was excessive and had some unintended side
effects (such as requiring me to not collectstatic in the test runner
due to weird errors, and unwanted logging setup). I've scaled this back
to just load django apps before running the tests.

Testing Done

Used rbext test successfully.

Issues

Description	From	Last Updated
I'm wondering if we should just expand the capabilities of initialize(). We have flags right now for turning off logging, …	chipx86	March 4, 2020, 10 p.m.
E402 module level import not at top of file	reviewbot	Feb. 19, 2020, 12:48 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

The issue has been dropped. Show all issues

I'm wondering if we should just expand the capabilities of initialize(). We have flags right now for turning off logging, extensions, and templates. We're unconditionally loading the siteconfig and emitting a signal. Maybe we want to add flags for those? Or some master flag that turns off everything but the bare-minimum?

Or maybe that's a terrible idea and we should just go with setting up Django. I don't really know what all was breaking.

david

March 4, 2020, 10 p.m.

It was breaking in a bunch of django-pipeline stuff. I think it's probably way easier to just stay with setting up django.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (69e1907)