Scale back changes to rbext a bit.

Review Request #10908 — Created Feb. 19, 2020 and submitted

david
Review Board
release-4.0.x
ca3f297...
reviewboard

I had made some changes to the rbext tool to completely initialize
Review Board, but this was excessive and had some unintended side
effects (such as requiring me to not collectstatic in the test runner
due to weird errors, and unwanted logging setup). I've scaled this back
to just load django apps before running the tests.

Used rbext test successfully.

Description From Last Updated

I'm wondering if we should just expand the capabilities of initialize(). We have flags right now for turning off logging, ...

chipx86chipx86

E402 module level import not at top of file

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
  1. 
      
  2. I'm wondering if we should just expand the capabilities of initialize(). We have flags right now for turning off logging, extensions, and templates. We're unconditionally loading the siteconfig and emitting a signal. Maybe we want to add flags for those? Or some master flag that turns off everything but the bare-minimum?

    Or maybe that's a terrible idea and we should just go with setting up Django. I don't really know what all was breaking.

    1. It was breaking in a bunch of django-pipeline stuff. I think it's probably way easier to just stay with setting up django.

  3. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (69e1907)
Loading...