Good ideas so far! Would this be a banner then or something else?
- I think also stating where and how the user can click to leave review comments would be beneficial. For example, stating that you could highlight one or more multiple lines from where the line numbers are would allow you to make comments
- For the expander buttons, you could also be more specific to what these look like (I also had trouble finding these when I first started reviewing haha). For example, the "+ #number of lines" button. OR they can click the Expand/Collapse changes button
- State where the revision selector is
- Its also a good idea to mention that reviewers can also select specific commits to view as well if many exist
xiaole2 got a fish trophy!
A mockup for the help bubble for the View Diff page.
Review Request #10901 — Created Feb. 12, 2020 and discarded
A mockup for the help bubble for the View Diff page. (go to All Review Requests -> select a review request --> click the diff at current page)
I wish I could get some suggestion about how you want to see when you first visit this page.
Also I wonder this help text would be there all the time or the first time users visit this page?
This is good! I like the cleaniess of the window.
Besides Monica's reviews, I have one more suggestion:
you have 3 tips in one window, which is very informative.
But will it be more user-friendly if these 3 tips are
shown saparately? For example, show 1 tip in one window,
and user can click on a
->button to see the next
tip in the same window.
+1 to Monica's comments about stating more clearly where users can take the actions you're describing in the help bubble! I think it might be nice to split up the content too, similar to what Xiaohui mentioned. I think it would probably be more helpful if they were inline to the actual actions they referred to as opposed to fixed to a single location in a banner/carousel. They could maybe come in the form of a question mark button next to the corresponding action eg. next to the revision selector that when clicked, shows a message or something like that.
Everybody left very good points on your review. Good job with the mockup!
Like others mentioned, the steps don't show how we do those steps, as well as why we would want to do those steps. I like Hannah's suggestion of having the help bubbles somewhere close to where we would do the actions, but if that't not possible, being more specific on how we can do those actions will suffice. I also like Xiaohui's suggestion of having the steps in separate areas. This way, we don't immediately bombard first time users with a series of steps or actions they can accomplish in this page.