• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    [WIP] Move keyBindings to basePageView.
    
 
    

    



 
    
 
    

  Review Request #10899
  —
  Created Feb. 9, 2020 and discarded  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  LittleGrey
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This is part of the "Keyboard shortcut registry" project.
    

    I moved keyBindings in diffViwerPage to basePageView so that
    
every page inherited from basePageView automatically have
    
keyboard shortcuts.
    

    Current keyBindings is only for diffViewerPage. I will add/change
    
the keybindings so that pages have more common keyboard shortcuts
    
(for example, press 't' jumps to topbar).
    
 
    

    





  

    
 
 
    
  
    Tested keys and callbacks in keyBindings on diffViewPage, functions
    
are not affected by moving keyBindings.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files