[WIP] Move keyBindings to basePageView.

Review Request #10899 — Created Feb. 9, 2020 and discarded

Information

Review Board
master

Reviewers

This is part of the "Keyboard shortcut registry" project.

I moved keyBindings in diffViwerPage to basePageView so that
every page inherited from basePageView automatically have
keyboard shortcuts.

Current keyBindings is only for diffViewerPage. I will add/change
the keybindings so that pages have more common keyboard shortcuts
(for example, press 't' jumps to topbar).

Tested keys and callbacks in keyBindings on diffViewPage, functions
are not affected by moving keyBindings.

Summary ID
[WIP] Move keyBindings to basePageView.
6ef87f9889282a0ec093cf9b083935ddaf1f81ee
Address styling warnings.
68e6a6578f828b284c131e5f07126bb6917aaf0a
Description From Last Updated

Col: 54 ['callback'] is better written in dot notation.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

LittleGrey
LittleGrey
Review request changed
Status:
Discarded