Summary:

[WIP] Move keyBindings to basePageView.

Review Request #10899 — Created Feb. 9, 2020 and discarded March 1, 2020, 3:01 p.m.

Information
Owner:	LittleGrey
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This is part of the "Keyboard shortcut registry" project.

I moved keyBindings in diffViwerPage to basePageView so that
every page inherited from basePageView automatically have
keyboard shortcuts.

Current keyBindings is only for diffViewerPage. I will add/change
the keybindings so that pages have more common keyboard shortcuts
(for example, press 't' jumps to topbar).

Testing Done

Tested keys and callbacks in keyBindings on diffViewPage, functions
are not affected by moving keyBindings.

Commits

Summary
[WIP] Move keyBindings to basePageView.
Address styling warnings.

Screenshots

Issues

Description	From	Last Updated
Col: 54 ['callback'] is better written in dot notation.	reviewbot	Feb. 9, 2020, 2:07 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/utils/keyBindingUtils.es6.js (Diff revision 1)
Show all issues
```
Col: 54
 ['callback'] is better written in dot notation.
```

Change Summary:

Address styling warnings.

Commits:

	Summary
-	[WIP] Move keyBindings to basePageView.
+	[WIP] Move keyBindings to basePageView.
+	Address styling warnings.

Diff:

Revision 2 (+86 -26)

Show changes

	reviewboard/static/rb/js/pages/views/basePageView.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
	reviewboard/static/rb/js/utils/keyBindingUtils.es6.js

Checks run (2 succeeded)