[WIP] Move keyBindings to basePageView.

Review Request #10899 — Created Feb. 9, 2020 and discarded

LittleGrey
Review Board
master
reviewboard

This is part of the "Keyboard shortcut registry" project.

I moved keyBindings in diffViwerPage to basePageView so that
every page inherited from basePageView automatically have
keyboard shortcuts.

Current keyBindings is only for diffViewerPage. I will add/change
the keybindings so that pages have more common keyboard shortcuts
(for example, press 't' jumps to topbar).

Tested keys and callbacks in keyBindings on diffViewPage, functions
are not affected by moving keyBindings.

Summary
Address styling warnings.
[WIP] Move keyBindings to basePageView.
Description From Last Updated

Col: 54 ['callback'] is better written in dot notation.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

LittleGrey
LittleGrey
Review request changed

Status: Discarded

Loading...