Summary

[WIP] Move keyBindings to basePageView.

Review Request #10899 — Created Feb. 9, 2020 and discarded March 1, 2020, 3:01 p.m.

Information

Owner

LittleGrey

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is part of the "Keyboard shortcut registry" project.

I moved keyBindings in diffViwerPage to basePageView so that
every page inherited from basePageView automatically have
keyboard shortcuts.

Current keyBindings is only for diffViewerPage. I will add/change
the keybindings so that pages have more common keyboard shortcuts
(for example, press 't' jumps to topbar).

Testing Done

Tested keys and callbacks in keyBindings on diffViewPage, functions
are not affected by moving keyBindings.

Commits

Summary	ID
[WIP] Move keyBindings to basePageView.	6ef87f9889282a0ec093cf9b083935ddaf1f81ee
Address styling warnings.	68e6a6578f828b284c131e5f07126bb6917aaf0a

Issues

Description	From	Last Updated
Col: 54 ['callback'] is better written in dot notation.	reviewbot	Feb. 9, 2020, 2:07 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/utils/keyBindingUtils.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 54
 ['callback'] is better written in dot notation.
```

Change Summary:

Address styling warnings.

Commits:

	Summary	ID
	[WIP] Move keyBindings to basePageView.	6ef87f9889282a0ec093cf9b083935ddaf1f81ee
	[WIP] Move keyBindings to basePageView.	6ef87f9889282a0ec093cf9b083935ddaf1f81ee
	Address styling warnings.	68e6a6578f828b284c131e5f07126bb6917aaf0a

Diff:

Revision 2 (+86 -26)

Show changes

	reviewboard/static/rb/js/pages/views/basePageView.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
	reviewboard/static/rb/js/utils/keyBindingUtils.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Discarded