Fix some presentation issues with the current form styling.

Review Request #10897 — Created Feb. 8, 2020 and submitted

Information

Review Board
release-4.0.x

Reviewers

This fixes a handful of issues that have come up with the form styling
in the administration UI:

  1. The old deprecated textarea definitions were badly copy/pasted, and
    most were set to the textarea font-size value, which broke a few
    things.

  2. Checkbox labels would move below the checkbox input if the label
    needed to wrap.

  3. Description areas for fieldsets had some pretty rough spacing.

  4. Input areas for fields didn't have access to the entire width of the
    form, causing some inputs to be too small when set to width: 100%.

Tested all the current forms in desktop and mobile modes, and at different
viewport widths, making sure they looked correct.

Tested a few places that used legacy textarea definitions, and saw that
they had the correct font and presentation.

Summary ID
Fix some presentation issues with the current form styling.
This fixes a handful of issues that have come up with the form styling in the administration UI: 1. The old deprecated textarea definitions were badly copy/pasted, and most were set to the textarea font-size value, which broke a few things. 2. Checkbox labels would move below the checkbox input if the label needed to wrap. 3. Description areas for fieldsets had some pretty rough spacing. 4. Input areas for fields didn't have access to the entire width of the form, causing some inputs to be too small when set to `width: 100%`.
fb311f9318c24f1a8876c72b30dcf3dbe591edc2
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (9944a22)
Loading...