Add inline help text for hosting services in Admin ADD REPOSITORY page.

 






 

 


  Review Request #10890
  —
  Created Feb. 6, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  xiaole2
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10872
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Create docs_url and summary attributes in class HostingService and SCMTools. 


Fill details in each hosting services (not include Kiln On Demand and Review Board Gateway, because right now we don't have references provided by ReviewBoard Manual. 


    

  1. 

    Hosting Servive: $hostingHelp is a new paragraph with class="hosting-help-text" in the template for the RepositoryForm javascript file. By default, $hostingHelp will nonvisiable. When users select a hosting service, the inline text will show up.
    

    2. 

  2. 

    SCMTools: $repoHelp is a new paragraph with class="repo-help-text" in the template for the RepositoryForm javascript file. Only when a user click 'custom' as the hosting service, $repoHelp will visiable. When users select a repo type, the inline text will show up.
    

    3. 


 








  


 
 

  
Tested in Google Chrome, Firefox and Safari. Inline Text of each hosting service displays correctly in the page.

Tested ./tests/runtests.py reviewboard.webapi.tests.test_hosting_service successfully.

 







 









 





  








 




 







   

    
    
Changes between revision 9 and 10



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Introduce attributes into HostingService and fill them in each hosting service

   
  		
  2a6ccd1291ce4a7ee0e6daa476581746918ec8db
  XiaoleZ
 


 
  
 
 
  
   
    
modify the coding format, remove trailing space

   
  		
  6f7e5929a9e6e17194154ead49c1851c70b9d6b1
  XiaoleZ
 


 
  
 
 
  
   
    
Create hosting-inline-help-text attribute in HostingService, and fill details...

   
  		
  6cb402906f926367ee30ffe61f73aa17d04ce5f6
  XiaoleZ
 


 
  
 
 
  
   
    
Remove extra () for import, and remove InlineHelpTextBase Class(wrong direction)

   
  		
  7f93220ec2ee97ebb9fa47f23e88f44454bff4ff
  XiaoleZ
 


 
  
 
 
  
   
    
split inline_help_text into two attributes, change toggle() into hide() and s...

   
  		
  8242552d4f4691d61596b590906154783ea0a3c7
  XiaoleZ
 


 
  
 
 
  
   
    
updatethe formate

   
  		
  b703e2486808e1c198ca85311a75bb0eeefea6b2
  XiaoleZ
 


 
  
 
 
  
   
    
remove trailing space for repositoryform.es6.js

   
  		
  e91a5a5ccb7b8fdf722ad29c8450652bedb2af23
  XiaoleZ
 


 
  
 
 
  
   
    
remove unicode(), replace html() with text(), add tag <a>

   
  		
  e5949471c53b9657c8e3dc524852a55238e6e1a3
  XiaoleZ
 


 
  
 
 
  
   
    
clean code

   
  		
  bd7a239ad3794236edec692506ad9ab96ca09427
  XiaoleZ
 


 
  
 
 
  
   
    
change repositoryform.js

   
  		
  1553bc047b737bda55e18c64c5445c46083ac4c5
  XiaoleZ
 


 
  
 
 
  
   
    
remove trailing space

   
  		
  7d4c990c50f7c9f1667dbfca7d0fe1421097055c
  XiaoleZ
 


 
  
 
 
  
   
    
add ;

   
  		
  c48807c335087689e3343ccfcb06845c868de0bf
  XiaoleZ
 


 
  
 
 
  
   
    
Introduce attributes into HostingService and fill them in each hosting service

   
  		
  1b72a08149f11e6c10cfe2ede34c6b5c6ff81f59
  XiaoleZ
 


 
  
 
 
  
   
    
modify the coding format, remove trailing space

   
  		
  ff9892ee229fcf88e61a52d1c1585f1ca6640da4
  XiaoleZ
 


 
  
 
 
  
   
    
Create hosting-inline-help-text attribute in HostingService, and fill details...

   
  		
  8b11f3fb2b0b57c56d2c52a756dabd3540f410d9
  XiaoleZ
 


 
  
 
 
  
   
    
Remove extra () for import, and remove InlineHelpTextBase Class(wrong direction)

   
  		
  514034994660be775f6422f2d8feb9a3c298a988
  XiaoleZ
 


 
  
 
 
  
   
    
split inline_help_text into two attributes, change toggle() into hide() and s...

   
  		
  0a771b3367d344f5af053ce91074542aa2c8ed89
  XiaoleZ
 


 
  
 
 
  
   
    
updatethe formate

   
  		
  d38b3e429225957b79c37d669c1887d7eb2d89e0
  XiaoleZ
 


 
  
 
 
  
   
    
remove trailing space for repositoryform.es6.js

   
  		
  1f67103471963d3ac64207f41429c3bf21091099
  XiaoleZ
 


 
  
 
 
  
   
    
remove unicode(), replace html() with text(), add tag <a>

   
  		
  e3def9304b6606ae125bf87f0f438028c3939dfe
  XiaoleZ
 


 
  
 
 
  
   
    
clean code

   
  		
  6493e05ae787c418b4e4f5c53028411432269814
  XiaoleZ
 


 
  
 
 
  
   
    
change repositoryform.js

   
  		
  5e407cd4f7180441074e93dd7bfb0789df9ae26d
  XiaoleZ
 


 
  
 
 
  
   
    
remove trailing space

   
  		
  1072019e93f36385a7a546e600db7cc7a13f5188
  XiaoleZ
 


 
  
 
 
  
   
    
add ;

   
  		
  07f64c66475ae1d56f98929e2df30950991868ac
  XiaoleZ
 


 
  
 
 
  
   
    
implementating scmtools

   
  		
  abdbba5ffd7473bc678e4c1582c8ed6b5bc363a2
  XiaoleZ
 


 
  
 
 
  
   
    
rebase from the master/setup repoHelp show() condition

   
  		
  9f18351952ca41754e2db9fcd7e062f88e83d222
  XiaoleZ
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/clearcase.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/cvs.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/git.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/hg.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/perforce.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/plastic.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/bzr/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/svn/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/repositoryform.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/hosting_service.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...