Add a CSS component for tip
Review Request #10872 — Created Jan. 31, 2020 and updated
Add a CSS component for tip.
Seperate tip section from pre-commit component.
Tested New Review Request page and tested color into red and yellow for hyperlink section.
Summary | ID | Author |
---|---|---|
021db2b2d5aa97383b97dfbf133fc938f748a1dd | XiaoleZ | |
d63df935491bb1c3dbe6f51dd8a794ba44aaced1 | XiaoleZ | |
a382718ca8237f71b9f3e993d90846fa5c5edffd | XiaoleZ |
Description | From | Last Updated |
---|---|---|
there's a lot of trailing whitespace that needs to be removed. also, what was the rationale for choosing the three … |
|
|
i think this commented out section needs to be removed |
|
|
shouldn't this be named according to the guidelines for css component naming? https://www.notion.so/reviewboard/CSS-LessCSS-Component-Style-Guide-ceb55ed87d954101a074f6601fc5deb2 something like rb-c-tip |
|
|
There's one trailing space here |
![]() |
-
-
there's a lot of trailing whitespace that needs to be removed. also, what was the rationale for choosing the three colors? i find the yellow hard to read
-
reviewboard/static/rb/css/pages/newReviewRequest.less (Diff revision 1) i think this commented out section needs to be removed
-
reviewboard/static/rb/css/ui/tips.less (Diff revision 1) shouldn't this be named according to the guidelines for css component naming? https://www.notion.so/reviewboard/CSS-LessCSS-Component-Style-Guide-ceb55ed87d954101a074f6601fc5deb2 something like
rb-c-tip

Change Summary:
Change name
tip
torb-c-tip
according to the guideline of css/less. Remove commented out code.
Commits: |
|
|||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+44 -30) |
Checks run (2 succeeded)

-
-
reviewboard/static/rb/css/pages/newReviewRequest.less (Diff revision 2) There's one trailing space here

Change Summary:
remove the trailing space.
Commits: |
|
|||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+45 -31) |