Add a CSS component for tip

Review Request #10872 — Created Jan. 31, 2020 and updated

xiaole2
Review Board
master
10890
reviewboard

Add a CSS component for tip.
Seperate tip section from pre-commit component.

Tested New Review Request page and tested color into red and yellow for hyperlink section.

Summary Author
create css component for tip
XiaoleZ
change tip to rb-c-tip, remove comment out code
XiaoleZ
remove the trailing space
XiaoleZ
Loading file attachments...

Description From Last Updated

there's a lot of trailing whitespace that needs to be removed. also, what was the rationale for choosing the three ...

hxqlinhxqlin

i think this commented out section needs to be removed

hxqlinhxqlin

shouldn't this be named according to the guidelines for css component naming? https://www.notion.so/reviewboard/CSS-LessCSS-Component-Style-Guide-ceb55ed87d954101a074f6601fc5deb2 something like rb-c-tip

hxqlinhxqlin

There's one trailing space here

LittleGreyLittleGrey
hxqlin
  1. 
      
  2. there's a lot of trailing whitespace that needs to be removed. also, what was the rationale for choosing the three colors? i find the yellow hard to read

    1. Hi Hannah, thanks for reviewing. I wonder how could I check the trailing whitespace for css file. I have checked manually, but I counld not find those trailing whitespace.

    2. color: @link-color; is what I have commited. I have changed @link-color to red and yellow for testing to check whether the css component works or not. I haven't commited the tested color(ie. red and yellow).

    3. ah i see sorry i misunderstood the screenshots. you seem to have caught most of the trailing whitespace but there's still one left - you can see it highlighted red in the diff.

  3. reviewboard/static/rb/css/pages/newReviewRequest.less (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    i think this commented out section needs to be removed

  4. reviewboard/static/rb/css/ui/tips.less (Diff revision 1)
     
     

    shouldn't this be named according to the guidelines for css component naming? https://www.notion.so/reviewboard/CSS-LessCSS-Component-Style-Guide-ceb55ed87d954101a074f6601fc5deb2 something like rb-c-tip

  5. 
      
xiaole2
LittleGrey
  1. 
      
  2. There's one trailing space here

  3. 
      
xiaole2
Review request changed

Change Summary:

remove the trailing space.

Commits:

Summary Author
-
create css component for tip
XiaoleZ
-
change tip to rb-c-tip, remove comment out code
XiaoleZ
+
create css component for tip
XiaoleZ
+
change tip to rb-c-tip, remove comment out code
XiaoleZ
+
remove the trailing space
XiaoleZ

Diff:

Revision 3 (+45 -31)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...