Add inline help text for hosting services in Admin ADD REPOSITORY page.

 






 

 


  Review Request #10890
  —
  Created Feb. 6, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  xiaole2
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10872
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Create docs_url and summary attributes in class HostingService and SCMTools. 


Fill details in each hosting services (not include Kiln On Demand and Review Board Gateway, because right now we don't have references provided by ReviewBoard Manual. 


    

  1. 

    Hosting Servive: $hostingHelp is a new paragraph with class="hosting-help-text" in the template for the RepositoryForm javascript file. By default, $hostingHelp will nonvisiable. When users select a hosting service, the inline text will show up.
    

    2. 

  2. 

    SCMTools: $repoHelp is a new paragraph with class="repo-help-text" in the template for the RepositoryForm javascript file. Only when a user click 'custom' as the hosting service, $repoHelp will visiable. When users select a repo type, the inline text will show up.
    

    3. 


 








  


 
 

  
Tested in Google Chrome, Firefox and Safari. Inline Text of each hosting service displays correctly in the page.

Tested ./tests/runtests.py reviewboard.webapi.tests.test_hosting_service successfully.

 







 









 





  








 




 







   

    
    
Diff Revision 9


This is not the most recent revision of the diff. The latest diff is revision 11. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Introduce attributes into HostingService and fill them in each hosting service

   
  		
  2a6ccd1291ce4a7ee0e6daa476581746918ec8db
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
modify the coding format, remove trailing space

   
  		
  6f7e5929a9e6e17194154ead49c1851c70b9d6b1
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
Create hosting-inline-help-text attribute in HostingService, and fill details...

   
  		
  6cb402906f926367ee30ffe61f73aa17d04ce5f6
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
Remove extra () for import, and remove InlineHelpTextBase Class(wrong direction)

   
  		
  7f93220ec2ee97ebb9fa47f23e88f44454bff4ff
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
split inline_help_text into two attributes, change toggle() into hide() and s...

   
  		
  8242552d4f4691d61596b590906154783ea0a3c7
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
updatethe formate

   
  		
  b703e2486808e1c198ca85311a75bb0eeefea6b2
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
remove trailing space for repositoryform.es6.js

   
  		
  e91a5a5ccb7b8fdf722ad29c8450652bedb2af23
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
remove unicode(), replace html() with text(), add tag <a>

   
  		
  e5949471c53b9657c8e3dc524852a55238e6e1a3
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
clean code

   
  		
  bd7a239ad3794236edec692506ad9ab96ca09427
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
change repositoryform.js

   
  		
  1553bc047b737bda55e18c64c5445c46083ac4c5
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
remove trailing space

   
  		
  7d4c990c50f7c9f1667dbfca7d0fe1421097055c
  XiaoleZ
 


 
  
   
  
  
   
  
 
 
  
   
    
add ;

   
  		
  c48807c335087689e3343ccfcb06845c868de0bf
  XiaoleZ
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/assembla.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/beanstalk.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/bitbucket.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/codebasehq.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/fake.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/gerrit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/github.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/gitlab.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/gitorious.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/kiln.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/service.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/sourceforge.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/unfuddle.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/forms.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/admin/repositoryform.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/hosting_service.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_hosting_service.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...