Add inline help text for hosting services in Admin ADD REPOSITORY page.

 






 

 


  Review Request #10890
  —
  Created Feb. 6, 2020 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  xiaole2
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  10872
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Create docs_url and summary attributes in class HostingService and SCMTools. 


Fill details in each hosting services (not include Kiln On Demand and Review Board Gateway, because right now we don't have references provided by ReviewBoard Manual. 


    

  1. 

    Hosting Servive: $hostingHelp is a new paragraph with class="hosting-help-text" in the template for the RepositoryForm javascript file. By default, $hostingHelp will nonvisiable. When users select a hosting service, the inline text will show up.
    

    2. 

  2. 

    SCMTools: $repoHelp is a new paragraph with class="repo-help-text" in the template for the RepositoryForm javascript file. Only when a user click 'custom' as the hosting service, $repoHelp will visiable. When users select a repo type, the inline text will show up.
    

    3. 


 








  


 
 

  
Tested in Google Chrome, Firefox and Safari. Inline Text of each hosting service displays correctly in the page.

Tested ./tests/runtests.py reviewboard.webapi.tests.test_hosting_service successfully.

 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 11. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
change tip to rb-c-tip, remove comment out code

   
  		
  d63df935491bb1c3dbe6f51dd8a794ba44aaced1
  XiaoleZ
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/css/pages/newReviewRequest.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/ui/tips.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/newReviewRequest/views/preCommitView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...