Summary

Only set a user's password during unit tests if one is provided.

Review Request #10887 — Created Feb. 6, 2020 and submitted Feb. 24, 2020, 4:18 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

TestCase.create_user() was unconditionally setting a user's password,
but if a password wasn't provided, the end result wasn't really correct.
We ran into this on RBCommons and fixed it there, but this fix is worth
backporting to Review Board.

This change simply makes the set_password() call conditional on
whether a password was provided.

Testing Done

Unit tests passed.

Commits

Summary	ID
Only set a user's password during unit tests if one is provided. `TestCase.create_user()` was unconditionally setting a user's password, but if a password wasn't provided, the end result wasn't really correct. We ran into this on RBCommons and fixed it there, but this fix is worth backporting to Review Board. This change simply makes the `set_password()` call conditional on whether a password was provided.	1f1a3735462717bcecbe4c6638df82458da24487

Summary

Only set a user's password during unit tests if one is provided.

`TestCase.create_user()` was unconditionally setting a user's password, but if a password wasn't provided, the end result wasn't really correct. We ran into this on RBCommons and fixed it there, but this fix is worth backporting to Review Board. This change simply makes the `set_password()` call conditional on whether a password was provided.

1f1a3735462717bcecbe4c6638df82458da24487

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (546808e)