Summary

Add a CSS component for nav support menu.

Review Request #10858 — Created Jan. 25, 2020 and updated Jan. 27, 2020, 6:56 p.m.

Information

Owner

xiaole2

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

.rb-help-icons .fa component provides a consistent style for the question-circle-icon for the navigation menu bar.
The help-icon shows after user login-in.
Add a new section into _nav_support_menu.html which provides useful resources, FAQ, etc. It consists of an icon and a list of information/docs field. The list will have links to corresponding informations.

Testing Done

Tested that Dashboard, Admin, Review Request UI works.

Commits

Summary	ID	Author
WIP Add a CSS component for nav support menu	13458081681b9e3e643d363adec0c4f8846b0742	XiaoleZ
WIP Add a CSS component for nav support menu	264c9169e412e8ca96aef4f84e1b53043d984488	XiaoleZ
WIP Add a CSS component for nav support menu	c5ef0b3b4817aa03b46abf428e27e422e1af5862	XiaoleZ
changed fa-question-circle to fa-question	5556cd15be0ffcfc4d7b15409206711614f2f376	XiaoleZ
Add a CSS component of help bubble for the homepage	14f622675842e7c1f9a3a644c383518e79f8a733	XiaoleZ
remove the help.less since I change the name to help-icon.less	3a8f747b9d781ba837ae8452655270d1da390074	XiaoleZ
change less file to alphabetical orader	4e0ca1df68533b6d1a0a701573351104ba2a0e0a	XiaoleZ
remove demo server& change to handy variable	6023bb8da1bad034393661da2e007c5670c9eb14	XiaoleZ

Files

Issues

Description	From	Last Updated
Is this line safe to be deleted? There is one empty line above it already.	LittleGrey	Jan. 27, 2020, 6:27 p.m.
There is an extra space here.	LittleGrey	Jan. 27, 2020, 6:27 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/ui/help.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Is this line safe to be deleted? There is one empty line above it already.
```
reviewboard/static/rb/css/ui/help.less (Diff revision 1)
The issue has been resolved. Show all issues
```
There is an extra space here.
```

Summary:

WIP Add a CSS component for nav support menu.

Add a CSS component for nav support menu.

Description:

~		This component is used to give useful resources, FAQ, etc.
~
~		It consists of an icon and a list of information/docs field. The list will have links to corresponding informations.
	~	`.rb-help-icons .fa` component provides a consistent style for the question-circle-icon for the navigation menu bar.
	~	The help-icon shows after user login-in.
	~	Add a new section into `_nav_support_menu.html` which provides useful resources, FAQ, etc. It consists of an icon and a list of information/docs field. The list will have links to corresponding informations.

Testing Done:

~		Tested that Dashboard UI works.
	~	Tested that Dashboard, Admin, Review Request UI works.

Commits:

Summary	ID	Author
WIP Add a CSS component for nav support menu	13458081681b9e3e643d363adec0c4f8846b0742	XiaoleZ
WIP Add a CSS component for nav support menu	264c9169e412e8ca96aef4f84e1b53043d984488	XiaoleZ
WIP Add a CSS component for nav support menu	c5ef0b3b4817aa03b46abf428e27e422e1af5862	XiaoleZ
changed fa-question-circle to fa-question	5556cd15be0ffcfc4d7b15409206711614f2f376	XiaoleZ
WIP Add a CSS component for nav support menu	13458081681b9e3e643d363adec0c4f8846b0742	XiaoleZ
WIP Add a CSS component for nav support menu	264c9169e412e8ca96aef4f84e1b53043d984488	XiaoleZ
WIP Add a CSS component for nav support menu	c5ef0b3b4817aa03b46abf428e27e422e1af5862	XiaoleZ
changed fa-question-circle to fa-question	5556cd15be0ffcfc4d7b15409206711614f2f376	XiaoleZ
Add a CSS component of help bubble for the homepage	14f622675842e7c1f9a3a644c383518e79f8a733	XiaoleZ
remove the help.less since I change the name to help-icon.less	3a8f747b9d781ba837ae8452655270d1da390074	XiaoleZ
change less file to alphabetical orader	4e0ca1df68533b6d1a0a701573351104ba2a0e0a	XiaoleZ

Diff:

Revision 2 (+98 -42)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/ui/help-icon.less
	reviewboard/templates/base/_nav_support_menu.html

Removed Files:

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

remove demo server and use handy variable for FAQ and Quick start

Commits:

Summary	ID	Author
WIP Add a CSS component for nav support menu	13458081681b9e3e643d363adec0c4f8846b0742	XiaoleZ
WIP Add a CSS component for nav support menu	264c9169e412e8ca96aef4f84e1b53043d984488	XiaoleZ
WIP Add a CSS component for nav support menu	c5ef0b3b4817aa03b46abf428e27e422e1af5862	XiaoleZ
changed fa-question-circle to fa-question	5556cd15be0ffcfc4d7b15409206711614f2f376	XiaoleZ
Add a CSS component of help bubble for the homepage	14f622675842e7c1f9a3a644c383518e79f8a733	XiaoleZ
remove the help.less since I change the name to help-icon.less	3a8f747b9d781ba837ae8452655270d1da390074	XiaoleZ
change less file to alphabetical orader	4e0ca1df68533b6d1a0a701573351104ba2a0e0a	XiaoleZ
WIP Add a CSS component for nav support menu	13458081681b9e3e643d363adec0c4f8846b0742	XiaoleZ
WIP Add a CSS component for nav support menu	264c9169e412e8ca96aef4f84e1b53043d984488	XiaoleZ
WIP Add a CSS component for nav support menu	c5ef0b3b4817aa03b46abf428e27e422e1af5862	XiaoleZ
changed fa-question-circle to fa-question	5556cd15be0ffcfc4d7b15409206711614f2f376	XiaoleZ
Add a CSS component of help bubble for the homepage	14f622675842e7c1f9a3a644c383518e79f8a733	XiaoleZ
remove the help.less since I change the name to help-icon.less	3a8f747b9d781ba837ae8452655270d1da390074	XiaoleZ
change less file to alphabetical orader	4e0ca1df68533b6d1a0a701573351104ba2a0e0a	XiaoleZ
remove demo server& change to handy variable	6023bb8da1bad034393661da2e007c5670c9eb14	XiaoleZ

Diff:

Revision 3 (+99 -45)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/css/ui/help-icon.less
	reviewboard/templates/base/_nav_support_menu.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.