Improve styling and modernize the template for Change Form pages.

Review Request #10850 — Created Jan. 23, 2020 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

This change completes much of the re-styling and re-implementation of
the administration UI's Change Form pages. It adds specialized styling
for some Django admin form widgets to help them better fit into our
pages and updates existing styles to fix up some small layout issues.

It also updates the main change form template to remove legacy cruft and
to take advantage of our modern CSS components. As part of this template
rewrite, we no longer pull in the Django admin UI form CSS. An upcoming
change will scrap the remainder of the Django styles and overrides,
paving the way for Django 1.11.

Tested every change form for every model in desktop and mobile modes,
making sure everything rendered as expected.

Summary
Improve styling and modernize the template for Change Form pages.
Loading file attachments...

Description From Last Updated

What's going on here?

daviddavid

Should this be /**?

daviddavid
david
  1. 
      
  2. Should this be /**?

    1. No, it's just a general comment explaining why the rules below exist.

  3. 
      
david
  1. 
      
    1. There are no permission groups, so no entries in this <select>. Chrome is opting to show it as just a scrollbar. Then, making it worse, something about the thing taking the screenshot in the browser did something to make that look even smaller than it does in reality.

      I'll put it on my list of things to enhance, add a min-width somewhere, but it's default browser behavior right now.

  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (51f54ff)
Loading...