Summary

Improve styling and modernize the template for Change Form pages.

Review Request #10850 — Created Jan. 23, 2020 and submitted Jan. 27, 2020, 1:51 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

It also updates the main change form template to remove legacy cruft and
to take advantage of our modern CSS components. As part of this template
rewrite, we no longer pull in the Django admin UI form CSS. An upcoming
change will scrap the remainder of the Django styles and overrides,
paving the way for Django 1.11.

Testing Done

Tested every change form for every model in desktop and mobile modes,
making sure everything rendered as expected.

Commits

Summary	ID
Improve styling and modernize the template for Change Form pages. This change completes much of the re-styling and re-implementation of the administration UI's Change Form pages. It adds specialized styling for some Django admin form widgets to help them better fit into our pages and updates existing styles to fix up some small layout issues. It also updates the main change form template to remove legacy cruft and to take advantage of our modern CSS components. As part of this template rewrite, we no longer pull in the Django admin UI form CSS. An upcoming change will scrap the remainder of the Django styles and overrides, paving the way for Django 1.11.	89663409ba908abcf7170a60499af693ec618431

Summary

Improve styling and modernize the template for Change Form pages.

This change completes much of the re-styling and re-implementation of the administration UI's Change Form pages. It adds specialized styling for some Django admin form widgets to help them better fit into our pages and updates existing styles to fix up some small layout issues. It also updates the main change form template to remove legacy cruft and to take advantage of our modern CSS components. As part of this template rewrite, we no longer pull in the Django admin UI form CSS. An upcoming change will scrap the remainder of the Django styles and overrides, paving the way for Django 1.11.

89663409ba908abcf7170a60499af693ec618431

Files

Issues

Description	From	Last Updated
What's going on here?	david	Jan. 24, 2020, 2:42 p.m.
Should this be /**?	david	Jan. 24, 2020, 2:43 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/pages/admin/change-form.less (Diff revision 1)
The issue has been dropped. Show all issues
```
Should this be /**?
```
1. chipx86 Jan. 24, 2020, 2:43 p.m.
  No, it's just a general comment explaining why the rules below exist.

Desktop mode (Revision 1)

The issue has been dropped. Show all issues

What's going on here?

chipx86 Jan. 24, 2020, 2:42 p.m.

There are no permission groups, so no entries in this <select>. Chrome is opting to show it as just a scrollbar. Then, making it worse, something about the thing taking the screenshot in the browser did something to make that look even smaller than it does in reality.

I'll put it on my list of things to enhance, add a min-width somewhere, but it's default browser behavior right now.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (51f54ff)