Summary

Add RB.FormView, a class for managing forms and fieldsets.

Review Request #10847 — Created Jan. 21, 2020 and submitted Jan. 27, 2020, 1:51 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This introduces RB.FormView, which is designed to be used with
.rb-c-form classes, and aids in managing forms. Right now, it's pretty
basic, offering only support for expanding/collapsing
.rb-c-form-fieldset components. Down the road, it'll be a useful place
for adding common form functionality that we're otherwise potentially
re-implementing in several other form implementations.

This is currently being used for the Change Form, to implement the
collapsed fieldset support there.

Testing Done

Unit tests passed.

Manually tested this with Change Form.

Commits

Summary	ID
Add RB.FormView, a class for managing forms and fieldsets. This introduces `RB.FormView`, which is designed to be used with `.rb-c-form` classes, and aids in managing forms. Right now, it's pretty basic, offering only support for expanding/collapsing `.rb-c-form-fieldset` components. Down the road, it'll be a useful place for adding common form functionality that we're otherwise potentially re-implementing in several other form implementations.	aef95126add6a622f7f7008ae606633ee080d1a0

Summary

Add RB.FormView, a class for managing forms and fieldsets.

This introduces `RB.FormView`, which is designed to be used with `.rb-c-form` classes, and aids in managing forms. Right now, it's pretty basic, offering only support for expanding/collapsing `.rb-c-form-fieldset` components. Down the road, it'll be a useful place for adding common form functionality that we're otherwise potentially re-implementing in several other form implementations.

aef95126add6a622f7f7008ae606633ee080d1a0

Issues

Description	From	Last Updated
Col: 51 Missing semicolon.	reviewbot	Jan. 21, 2020, 4:34 p.m.
Col: 48 Missing semicolon.	reviewbot	Jan. 21, 2020, 4:34 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/ui/views/formView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 51
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/formView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 48
 Missing semicolon.
```

Change Summary:

Added missing semicolons.

Commits:

	Summary	ID
	Add RB.FormView, a class for managing forms and fieldsets. This introduces `RB.FormView`, which is designed to be used with `.rb-c-form` classes, and aids in managing forms. Right now, it's pretty basic, offering only support for expanding/collapsing `.rb-c-form-fieldset` components. Down the road, it'll be a useful place for adding common form functionality that we're otherwise potentially re-implementing in several other form implementations.	dfd21f494dbebe0388445af65087831fd497ca9a
	Add RB.FormView, a class for managing forms and fieldsets. This introduces `RB.FormView`, which is designed to be used with `.rb-c-form` classes, and aids in managing forms. Right now, it's pretty basic, offering only support for expanding/collapsing `.rb-c-form-fieldset` components. Down the road, it'll be a useful place for adding common form functionality that we're otherwise potentially re-implementing in several other form implementations.	aef95126add6a622f7f7008ae606633ee080d1a0

Diff:

Revision 2 (+198)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/admin/views/changeFormPageView.es6.js
	reviewboard/static/rb/js/ui/views/formView.es6.js
	reviewboard/static/rb/js/ui/views/tests/formViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (4e0f9e4)