Summary

Add unit tests for djblets.log.views

Review Request #10833 — Created Jan. 18, 2020 and updated Jan. 20, 2020, 8:37 p.m.

Information

Owner

xiaole2

Repository

Djblets

Branch

release-1.0.x

Bugs

4590

Depends On

Commit

2b03f4b...

Reviewers

Groups

djblets

People

Description

Add a unit test for djblets.log.views.
Adding parse_timestamp() tests, def build_query_string() tests, iter_log_lines() tests, and get_log_filtersets() tests.

Testing Done


Added a unit test for djblets.log.views, which passes (along with all other tests except ERROR: Failure: ImproperlyConfigured (Error loading MySQLdb module: No module named MySQLdb)).
Running ./tests/runtests.py djblets.log.tests passes all tests.

Issues

Description	From	Last Updated
F401 'time' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
F401 'logging' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
F401 'importlib.import_module' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
F401 'django.db.connection' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1 p.m.
F401 'django.contrib.auth.models.AnonymousUser' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
F401 'djblets.log.views.server_log' imported but unused	reviewbot	Jan. 18, 2020, 1 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 18, 2020, 1 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Jan. 18, 2020, 1 p.m.
E501 line too long (119 > 79 characters)	reviewbot	Jan. 18, 2020, 1 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:01 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1:01 p.m.
E231 missing whitespace after ':'	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (92 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (99 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E225 missing whitespace around operator	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (89 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (92 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Jan. 18, 2020, 1:01 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1:02 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 18, 2020, 1:03 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1:18 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:05 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:18 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:06 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:18 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:06 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:06 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:06 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:06 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:42 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1:06 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:06 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:07 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:07 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:07 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:07 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:07 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:07 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:07 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 1:08 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:08 p.m.
E225 missing whitespace around operator	reviewbot	Jan. 18, 2020, 1:08 p.m.
E502 the backslash is redundant between brackets	reviewbot	Jan. 18, 2020, 1:42 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:42 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:09 p.m.
E502 the backslash is redundant between brackets	reviewbot	Jan. 18, 2020, 1:42 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:18 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:10 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 18, 2020, 1:59 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 18, 2020, 1:59 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:43 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E202 whitespace before ')'	reviewbot	Jan. 18, 2020, 1:44 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1:44 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1:44 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1:44 p.m.
E231 missing whitespace after ','	reviewbot	Jan. 18, 2020, 1:44 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:44 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:44 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:44 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 1:44 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:44 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:45 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 1:45 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 1:45 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Jan. 18, 2020, 1:45 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 3:36 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 3:36 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 3:36 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 3:36 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E203 whitespace before ','	reviewbot	Jan. 18, 2020, 3:36 p.m.
W291 trailing whitespace	reviewbot	Jan. 18, 2020, 3:36 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Jan. 18, 2020, 3:36 p.m.
E303 too many blank lines (3)	reviewbot	Jan. 18, 2020, 3:36 p.m.
W293 blank line contains whitespace	reviewbot	Jan. 18, 2020, 3:40 p.m.
Some important notes for the whole start-of-file area, including imports: Each file needs a docstring. Even unit test files. Something …	chipx86	Jan. 18, 2020, 9:35 p.m.
While it's great practice to put docstrings in functions (and we highly encourage it), the exception is actually setUp() and …	chipx86	Jan. 18, 2020, 9:07 p.m.
There's a ton of modules named "views," so the "views" prefix in here isn't really all that helpful. We tend …	chipx86	Jan. 19, 2020, 1 a.m.
These variables can go inline in the call. Keeps the test nice and tidy, and makes it easier to copy/paste …	chipx86	Jan. 18, 2020, 10:24 p.m.
When comparing against None, you'll want to use assertIsNone (or assertIsNotNone).	chipx86	Jan. 18, 2020, 9:40 p.m.
We don't generally prefix with "mock," because at the end of the day it just becomes additional noise in the …	chipx86	Jan. 18, 2020, 10:25 p.m.
A space snuck in at the end of this docstring. Same on some other ones.	chipx86	Jan. 19, 2020, 1:01 a.m.
We want to always use single quotes instead of double quotes, unless the string itself contains single quotes (like "It's'a …	chipx86	Jan. 18, 2020, 9:45 p.m.
We always like to expand dictionaries, so that it's easier to add to them without reformatting everything and easier to …	chipx86	Jan. 18, 2020, 10:34 p.m.
You can nuke this blank line. Same with any others that introduce one. The only time we do want a …	chipx86	Jan. 18, 2020, 9:51 p.m.
Good practice in Python when concatenating strings is to use a format string. It's faster than using +. So: '%s.log' …	chipx86	Jan. 18, 2020, 9:55 p.m.
Here's some places we do want a blank line. Any time you are: Separating two blocks from each other (exception …	chipx86	Jan. 18, 2020, 10:10 p.m.
Since the line_info[1] values are never going to change, you'll be better served with elif blocks.	chipx86	Jan. 18, 2020, 10:11 p.m.
The u'...' string prefixes are old, and not something we want to use anymore. They imply a Unicode string, which …	chipx86	Jan. 19, 2020, 12:30 a.m.
You'll want a blank line between these (separating a statement from a block).	chipx86	Jan. 18, 2020, 10:13 p.m.
While commonly done in Python programs, it's actually dangerous for us to assign anything to _. That's because _ is …	chipx86	Jan. 19, 2020, 12:28 a.m.
Looks like a blank line snuck in here.	chipx86	Jan. 18, 2020, 10:32 p.m.
W291 trailing whitespace	reviewbot	Jan. 19, 2020, 1:03 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Jan. 19, 2020, 1:04 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Jan. 19, 2020, 1:04 a.m.
E126 continuation line over-indented for hanging indent	reviewbot	Jan. 19, 2020, 1:05 a.m.
E126 continuation line over-indented for hanging indent	reviewbot	Jan. 19, 2020, 1:05 a.m.
E126 continuation line over-indented for hanging indent	reviewbot	Jan. 19, 2020, 1:05 a.m.
E126 continuation line over-indented for hanging indent	reviewbot	Jan. 19, 2020, 1:06 a.m.
unicode(name) doesn't work in Python 3 because the unicode function got removed. Do we need the unicode thing at all? …	mike_conley	Jan. 20, 2020, 8:29 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 198 failures.
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'time' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'logging' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'importlib.import_module' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.db.connection' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'django.contrib.auth.models.AnonymousUser' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'djblets.log.views.server_log' imported but unused
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (119 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (92 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (99 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E225 missing whitespace around operator
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (89 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (92 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (91 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```

Commit:

-	b77030c384038039c44de6b93c61d4c5bdddab2c
+	8443d35ba5fe0f1a9b60b17cff49449ee4739eea

Diff:

Revision 2 (+366 -1)

Show changes

	djblets/log/views.py
	djblets/log/tests/test_log_view.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 216 failures.
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E225 missing whitespace around operator
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

Commit:

-	8443d35ba5fe0f1a9b60b17cff49449ee4739eea
+	735d9f71352287a4a857d7e63159d0b19a5434ff

Diff:

Revision 3 (+367 -1)

Show changes

	djblets/log/views.py
	djblets/log/tests/test_log_view.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 146 failures.
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E202 whitespace before ')'
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

Commit:

-	735d9f71352287a4a857d7e63159d0b19a5434ff
+	22bfd68832391f39290e5a0074cbc9757e60baeb

Diff:

Revision 4 (+363 -1)

Show changes

	djblets/log/views.py
	djblets/log/tests/test_log_view.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 87 failures.
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E501 line too long (81 > 79 characters)
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/log/tests/test_log_view.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E303 too many blank lines (3)
```

Commit:

-	22bfd68832391f39290e5a0074cbc9757e60baeb
+	d10b356249d244d6988589c4ae20c97ee48ecb6d

Diff:

Revision 5 (+383 -1)

Show changes

	djblets/log/views.py
	djblets/log/tests/test_log_view.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/log/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Bugs:

+	4590

Commit:

-	d10b356249d244d6988589c4ae20c97ee48ecb6d
+	3d3eeeaf89212f8ad505a0ef9887d870c0221c36

Diff:

Revision 6 (+382)

Show changes

	djblets/log/views.py
	djblets/log/tests/test_log_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

This is a great batch of new unit tests. Should definitely help us catch regressions in the future.

There's some stuff I'll have you fix up. Mostly having to do with styles and standards, simplifying the number of lines of code in some tests, some gotchas you wouldn't otherwise know to look for, etc., but the core test logic looks sound.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

Some important notes for the whole start-of-file area, including imports:

Each file needs a docstring. Even unit test files. Something like """Unit tests for djblets.log.views.""" is fine (it's not uncommon for this to match the class's docstring in these cases).
The very first import must be from __future__ import unicode_literals, since that tells Python we want string compatibility between Python 2 and 3 (makes all strings Unicode by default). This avoids a LOT of problems.
There's a bunch of conventions for imports that must be followed. See the coding style guide for information on this.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

While it's great practice to put docstrings in functions (and we highly encourage it), the exception is actually setUp() and tearDown() in unit tests.

The reason basically just boils down to these functions being just part of the test infrastructure, and are so common that a docstring doesn't add anything. We're not generating codebase docs from them. We're not educating anyone with them. We'd just have a thousand variations on "Setting up for the test." So we don't really need to bother.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

There's a ton of modules named "views," so the "views" prefix in here isn't really all that helpful. We tend not to put module names in docstrings. You can instead just say "Testing parse_timestamp ...."

This applies to the other ones below.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

These variables can go inline in the call. Keeps the test nice and tidy, and makes it easier to copy/paste these into a shell or something if we need to manually duplicate behavior.

This will apply to a bunch of others below. Basically, any values that are only used once should just go inline in the call.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

When comparing against None, you'll want to use assertIsNone (or assertIsNotNone).

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

We don't generally prefix with "mock," because at the end of the day it just becomes additional noise in the test. Most values are going to be mock/fake/dummy/test data, so we can just assume that to be the case.

While you'll want to put these values directly into the call instead, if you were to pull them out (some later ones make sense since they're reused), I'd go with timestamp_format and timestamp_str.

djblets/log/tests/test_log_view.py (Diff revision 6)
The issue has been resolved. Show all issues
```
A space snuck in at the end of this docstring. Same on some other ones.
```

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

We want to always use single quotes instead of double quotes, unless the string itself contains single quotes (like "It's'a me, Mario!").

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

We always like to expand dictionaries, so that it's easier to add to them without reformatting everything and easier to scan for all the keys/values.

Though that said, like above, let's just make these inline:

self.assertEqual(
    build_query_string(request, {
        'hello': 'world',
    }),
    '?hello=world')

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

You can nuke this blank line. Same with any others that introduce one.

The only time we do want a blank line after a docstring is for classes. I know, that sounds inconsistent, but it's a Python standard.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

Good practice in Python when concatenating strings is to use a format string. It's faster than using +. So:

'%s.log' % settings.LOGGING_NAME

These apply to other tests as well.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

Here's some places we do want a blank line. Any time you are:

Separating two blocks from each other (exception being something like if/elif/else or try/except/finally)
Separating statement from a block (like a variable followed by an if or for)
Separating a block from a statement

Think of each for loop as its own paragraph. It'll make it easier to read.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

Since the line_info[1] values are never going to change, you'll be better served with elif blocks.

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

The u'...' string prefixes are old, and not something we want to use anymore. They imply a Unicode string, which is the default on Python 3 and the default for any Python 2 files that do from __future__ import unicode_literals (which should be every single Python file we write).

djblets/log/tests/test_log_view.py (Diff revision 6)
The issue has been resolved. Show all issues
```
You'll want a blank line between these (separating a statement from a block).
```

djblets/log/tests/test_log_view.py (Diff revision 6)

The issue has been resolved. Show all issues

While commonly done in Python programs, it's actually dangerous for us to assign anything to _. That's because _ is used as an alias for ugettext, which is for string translations. It could potentially be overridden if someone's not careful, and it's also scanned by the program that generates the string translation files.

Instead, just tack a [1] on the end of the statement or, maybe more correctly, name this value and then test it for correctness.

djblets/log/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Looks like a blank line snuck in here.
```

Commit:

-	3d3eeeaf89212f8ad505a0ef9887d870c0221c36
+	2e7340ef24aa1eda0f070dcb0941400729180b62

Diff:

Revision 7 (+382)

Show changes

djblets/log/tests/test_log_view.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```
djblets/log/tests/test_log_view.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E126 continuation line over-indented for hanging indent
```

Change Summary:

make changes accrording to Christian's comments.

Major changes:

1. edit import format

2. change "" to ''

3. expand dictionaries

4. take variables go inline in the call

5. littles changes based on Christian's comments

Commit:

-	2e7340ef24aa1eda0f070dcb0941400729180b62
+	e88ef3ff6171c8df91636705916c36a3d1cc06a0

Diff:

Revision 8 (+382)

Show changes

djblets/log/tests/test_log_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Thanks, Xiaole! Nice tests. Just one thing from what I can tell - see below.

djblets/log/tests/test_log_view.py (Diff revision 8)

The issue has been resolved. Show all issues

unicode(name) doesn't work in Python 3 because the unicode function got removed.
Do we need the unicode thing at all? What happens if we just use:

self.assertEqual(name, 'By date')

?
Same goes for the other places where you use unicode() in this file.

xiaole2 Jan. 20, 2020, 8:29 p.m.

Do we need the unicode thing at all? - We don't need this thing. I have removed them and the tests all passed.
self.assertEqual(name, 'By date') pass

Change Summary:

removed unicode() and all tests pass

Commit:

-	e88ef3ff6171c8df91636705916c36a3d1cc06a0
+	2b03f4b44e507ce16e81cceeff03ae2e4d76049a

Diff:

Revision 9 (+382)

Show changes

djblets/log/tests/test_log_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.