Extracted serialization code out of WebAPIResponse

Review Request #1083 — Created Sept. 19, 2009 and discarded

Information

Djblets
http://github.com/obvio171/djblets/tree/serialization

Reviewers

This stuff can be reused in other pure serialization contexts (namely, webhook payloads), not only in HTTP responses.

This is an updated version of the review request at http://reviews.review-board.org/r/982, now using the github repository.
Ran ReviewBoard test suite with it, passed all tests.
david
  1. 
      
  2. djblets/webapi/core.py (Diff revision 1)
     
     
    This can just be "if result:"
  3. djblets/webapi/core.py (Diff revision 1)
     
     
    You don't need this. The return value is automatically None if there's no return statement.
    1. Ain't it clearer this way ?
    2. I'd have to agree. I like explicit returns.
  4. djblets/webapi/core.py (Diff revision 1)
     
     
    if not result:
  5. djblets/webapi/core.py (Diff revision 1)
     
     
    While you're in here, can you change this to just be "if self.callback:"?
  6. 
      
HE
Review request changed

Status: Discarded

Loading...