Summary:

Extracted serialization code out of WebAPIResponse

Review Request #1083 — Created Sept. 19, 2009 and discarded Sept. 22, 2012, 3:43 p.m.

Information
Owner:	helder
Repository:	Djblets
Branch:	http://github.com/obvio171/djblets/tree/serialization
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This stuff can be reused in other pure serialization contexts (namely, webhook payloads), not only in HTTP responses.

This is an updated version of the review request at http://reviews.review-board.org/r/982, now using the github repository.

Testing Done

Ran ReviewBoard test suite with it, passed all tests.

djblets/webapi/core.py (Diff revision 1)
```
This can just be "if result:"
```

djblets/webapi/core.py (Diff revision 1)

You don't need this. The return value is automatically None if there's no return statement.

SG

sgdf Feb. 10, 2010, 6:24 a.m.
```
Ain't it clearer this way ?
```

chipx86 Feb. 11, 2010, 1:36 p.m.

I'd have to agree. I like explicit returns.

djblets/webapi/core.py (Diff revision 1)
```
if not result:
```

djblets/webapi/core.py (Diff revision 1)

While you're in here, can you change this to just be "if self.callback:"?

Review Board 6.0 alpha 0 (dev)

Extracted serialization code out of WebAPIResponse

Status: Discarded