Summary

Modernize the List Edit form widget for Django 1.11 and CSS Components.

Review Request #10823 — Created Jan. 13, 2020 and submitted Jan. 13, 2020, 1:54 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This redoes much of the List Edit form widget, used for dynamically

adding/removing lists of text fields, to be compatible with Django 1.11

(by removing references to old, removed Django static media files). This

allows the Djblets test suite to fully pass on Django 1.11.
I've also moved the widget to use CSS Components, which will help us to

maintain consistent styling and reduce namespace clashes.
While updating the JavaScript for this widget, some unused code was

found and removed, and an HTML formatting bug was also fixed.

Testing Done

Python and JavaScript unit tests pass.

Commits

Summary	ID
Modernize the List Edit form widget for Django 1.11 and CSS Components. This redoes much of the List Edit form widget, used for dynamically adding/removing lists of text fields, to be compatible with Django 1.11 (by removing references to old, removed Django static media files). This allows the Djblets test suite to fully pass on Django 1.11. I've also moved the widget to use CSS Components, which will help us to maintain consistent styling and reduce namespace clashes. While updating the JavaScript for this widget, some unused code was found and removed, and an HTML formatting bug was also fixed.	65e3b5f7cebaed6b0d14c4fcf58076c44c23c191

Summary

Modernize the List Edit form widget for Django 1.11 and CSS Components.

This redoes much of the List Edit form widget, used for dynamically adding/removing lists of text fields, to be compatible with Django 1.11 (by removing references to old, removed Django static media files). This allows the Djblets test suite to fully pass on Django 1.11. I've also moved the widget to use CSS Components, which will help us to maintain consistent styling and reduce namespace clashes. While updating the JavaScript for this widget, some unused code was found and removed, and an HTML formatting bug was also fixed.

65e3b5f7cebaed6b0d14c4fcf58076c44c23c191

flake8 passed.

JSHint passed.

Change Summary:

Added the missing updates to the Python unit tests.

Commits:

	Summary	ID
	Modernize the List Edit form widget for Django 1.11 and CSS Components. This redoes much of the List Edit form widget, used for dynamically adding/removing lists of text fields, to be compatible with Django 1.11 (by removing references to old, removed Django static media files). This allows the Djblets test suite to fully pass on Django 1.11. I've also moved the widget to use CSS Components, which will help us to maintain consistent styling and reduce namespace clashes. While updating the JavaScript for this widget, some unused code was found and removed, and an HTML formatting bug was also fixed.	a22d63d42181d27567aeebe7d9cabce822768d24
	Modernize the List Edit form widget for Django 1.11 and CSS Components. This redoes much of the List Edit form widget, used for dynamically adding/removing lists of text fields, to be compatible with Django 1.11 (by removing references to old, removed Django static media files). This allows the Djblets test suite to fully pass on Django 1.11. I've also moved the widget to use CSS Components, which will help us to maintain consistent styling and reduce namespace clashes. While updating the JavaScript for this widget, some unused code was found and removed, and an HTML formatting bug was also fixed.	65e3b5f7cebaed6b0d14c4fcf58076c44c23c191

Diff:

Revision 2 (+426 -268)

Show changes

	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_widget.py
	djblets/static/djblets/css/forms/list_edit.less
	djblets/static/djblets/js/forms/views/listEditView.es6.js
	djblets/static/djblets/js/forms/views/tests/listEditViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (fde03c2)