Summary

Fix indirect dependency for django-braces and asana.

Review Request #10816 — Created Jan. 6, 2020 and submitted Jan. 6, 2020, 8:27 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

48eee0b...

Reviewers

Groups

reviewboard

People

Description

We have a couple dependencies which in turn have dependencies which have
versions that can conflict with Django 1.6. django-oauth-toolkit depends
on django-braces and asana depends on requests-oauthlib. In both cases,
we're adding explicit dependencies on the upstream packages and pin
versions which are known to work.

Testing Done

Was able to set up a new virtualenv without any warnings or errors.

flake8 passed.

JSHint passed.

Commit:

-	5c1ea83a7c64074da5bf316011b4e1b18a6a6a44
+	0303cffccaaee8397a3abf562f978a45250ff422

Diff:

Revision 2 (+8)

Show changes

reviewboard/dependencies.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Fix indirect dependency for django-braces.
+	Fix indirect dependency for django-braces and asana.

Description:

~		django-oauth-toolkit has a dependency on django-braces, but doesn't
~		specify a version. Unfortunately, the most recent version of
~		django-braces conflicts with Django 1.6 for no reason other than it's
~		EOL. This change adds an explicit dependency on django-braces==1.13.0,
~		allowing everything to install smoothly.
	~	We have a couple dependencies which in turn have dependencies which have
	~	versions that can conflict with Django 1.6. django-oauth-toolkit depends
	~	on django-braces and asana depends on requests-oauthlib. In both cases,
	~	we're adding explicit dependencies on the upstream packages and pin
	~	versions which are known to work.