Relabel the repository Publicly Accessible checkbox based on settings.

Review Request #10811 — Created Dec. 10, 2019 and submitted

chipx86
Review Board
release-3.0.x
7dbbda8...
reviewboard

The repository configuration form's "Publicly accessible" checkbox has
confused a few people in the past, with some thinking it would made a
repository available to people without access to the Local Site owning
the repository, or to those without login credentials on a server.

To address this, we're now giving the checkbox a more explicit label and
help text to better describe the effects that the setting will have.

When used with a non-public Local Site, the checkbox will say
"Accessible to all users on <sitename>", with accompanying help text
that clarifies this further.

When used on a public Local Site or without a Local Site, the checkbox
will reflect the server's site-wide login setting, saying either
"Accessible to all logged-in users" or "Accessible to everyone."

Unit tests were added to ensure that the correct text is used in each
circumstance, and to check both the configured Local Site or when
limiting the form to a Local Site.

Tested each possible configuration manually.

Unit tests passed.

Loading file attachments...

Description From Last Updated

F811 redefinition of unused 'test_public_checkbox_with_limit_local_site_public' from line 1718

reviewbotreviewbot

F811 redefinition of unused 'test_public_checkbox_with_limit_local_site_public' from line 1736

reviewbotreviewbot

F811 redefinition of unused 'test_public_checkbox_with_limit_local_site_public' from line 1668

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed

Change Summary:

Fixed duplicate function definitions.

Commit:

-d36725f8e696a9bba02997476f5eb826e09c2784
+6f77e51efc96e3d47918788295b7d175a16aaadd

Diff:

Revision 2 (+149)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (b23cbc0)
Loading...