Clear out a repository's ACLs when marking it public.

Review Request #10810 — Created Dec. 10, 2019 and submitted

chipx86
Review Board
release-3.0.x
e01f773...
reviewboard

When setting ACLs on a repository (invite-only review groups and users),
saving the repository, and then making the repository
publicly-accessible to the team, the ACLs were remaining as part of the
repository's settings. This caused problems down the road in situations
such as a repository being owned by a Local Site and a user on an ACL
being removed from the site, which would trigger a hidden validation
error and prevent saving the repository.

We now clear out the ACLs whenever we make a repository public, or when
loading a public repository into the repository form. This should
prevent this sort of problem from occurring in the future, and better
meet user expectations.

Tested loading and saving public repositories that had ACLs set, and
verified that the ACLs were removed.

Tested loading and saving private repositories that had ACLs set.

Unit tests passed.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (bb5c5a3)
Loading...