Summary

Added audio review UI.

Review Request #10798 — Created Nov. 13, 2019 and updated Dec. 1, 2019, 8:23 p.m.

Information

Owner

amalik2

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Review UI for audio files, with a waveform graph and a spectrogram that can be
toggled on or off.

When comparing two different revisions, the old revision will be rendered
first, and the new revision will be underneath it. Each revision has its own
set of controls as well, and both revisions can be concurrently played.

Comments can be added by dragging a region of the waveform graph, which will
pop up a dialog where the user can add in a comment. After creating the comment,
it will be added to the waveform graph.

Hovering over a comment region on the waveform graph will show details about it
in a tooltip, similar to other review UIs. When a comment region is clicked, it
will allow the user to edit or delete their comment if the shift key is not
pressed. If the shift key is pressed, then the audio player will play just the
selected region.

Testing Done


Tested manually with Python2.7 and Python3.6 with a short audio file.
Tested manually with Python2.7 with a long audio file.
Tested the diff viewer manually with Python2.7 and Python3.6.
Ran JavaScript unit tests with Python2.7.

Commits

Summary	ID	Author
Added review UI for audio files.	cb684a5f2f50025ad8121f29ce0574031b8134c4	amalik2

Files

Issues

Description	From	Last Updated
F821 undefined name 'crop_image'	reviewbot	Nov. 22, 2019, 11:31 p.m.
F821 undefined name 'crop_image'	reviewbot	Nov. 22, 2019, 11:31 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Nov. 22, 2019, 11:31 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Nov. 22, 2019, 11:31 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Nov. 22, 2019, 11:31 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 213 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 395 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 493 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 668 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:23 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 936 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 960 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1027 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1048 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1071 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1139 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1156 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:24 p.m.
Col: 1314 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:25 p.m.
Col: 1396 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:25 p.m.
F821 undefined name 'crop_image'	reviewbot	Nov. 26, 2019, 7:26 p.m.
F821 undefined name 'crop_image'	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 213 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 395 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 493 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:26 p.m.
Col: 668 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 936 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 960 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1027 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1048 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1071 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1139 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1156 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1314 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
Col: 1396 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:27 p.m.
F821 undefined name 'crop_image'	reviewbot	Nov. 26, 2019, 7:28 p.m.
F821 undefined name 'crop_image'	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 213 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 395 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 493 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 668 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Nov. 26, 2019, 7:28 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 936 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 960 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1027 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1048 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1071 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1139 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1156 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1314 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 1396 Missing semicolon.	reviewbot	Nov. 26, 2019, 7:29 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 213 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 395 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 493 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 668 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 936 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 960 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1027 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1048 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1071 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1139 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1156 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1314 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 1396 Missing semicolon.	reviewbot	Nov. 27, 2019, 5:32 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 213 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 395 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 493 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 668 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 936 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 960 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1027 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1048 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1071 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1139 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1156 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1314 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 1396 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:21 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 52 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 97 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 159 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 212 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 213 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 44413 A leading decimal point can be confused with a dot: '.5'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 284 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 395 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 492 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 493 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 524 Expected '!==' and instead saw '!='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 667 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 668 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 709 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 736 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 762 Expected '{' and instead saw 'return'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 881 Expected '!==' and instead saw '!='.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 890 Expected '{' and instead saw 'for'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 905 Expected '{' and instead saw 'r'.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 936 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 913 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 960 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1027 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1048 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1071 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1139 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1156 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1314 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.
Col: 1396 Missing semicolon.	reviewbot	Dec. 1, 2019, 8:23 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/ui/audio.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```
reviewboard/reviews/ui/audio.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```

JSHint

```
Warning: Showing 30 of 102 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)

The issue has been resolved. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1396
 Missing semicolon.
```

Commits:

Summary	ID	Author
started on audio player	b9e3f1766232a3cb58ea71fe5fa9d062062ffa40	amalik2
started on audio player	b9e3f1766232a3cb58ea71fe5fa9d062062ffa40	amalik2
Added volume slider	5c993bb8f3c2dc3540dbdc7b6b8c663ad7ce9c0a	amalik2

Diff:

Revision 2 (+1973 -71)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/audio.py
	reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-spectrogram-3.2.0.min.js
	reviewboard/static/rb/css/pages/audio-review-ui.less
	reviewboard/static/rb/js/models/audioReviewableModel.es6.js
	reviewboard/static/rb/js/views/audioReviewableView.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/ui/audio.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```
reviewboard/reviews/ui/audio.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```

JSHint

```
Warning: Showing 30 of 102 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)

The issue has been resolved. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1396
 Missing semicolon.
```

Description:

~		Review UI for audio files, with a waveform graph and a spectrogram.
	~	Review UI for audio files, with a waveform graph and a spectrogram that can be
	+	toggled on or off.
	+
	+	When comparing two different revisions, the old revision will be rendered
	+	first, and the new revision will be underneath it. Each revision has its own
	+	set of controls as well, and both revisions can be concurrently played.
	+
	+	Comments can be added by dragging a region of the waveform graph, which will
	+	pop up a dialog where the user can add in a comment.

Commits:

Summary	ID	Author
started on audio player	b9e3f1766232a3cb58ea71fe5fa9d062062ffa40	amalik2
Added volume slider	5c993bb8f3c2dc3540dbdc7b6b8c663ad7ce9c0a	amalik2
started on audio player	b9e3f1766232a3cb58ea71fe5fa9d062062ffa40	amalik2
Added volume slider	5c993bb8f3c2dc3540dbdc7b6b8c663ad7ce9c0a	amalik2
more work on audio review ui	0f3cf9197eb8c45b607e02afaa3270e28ac9f7d6	amalik2

Diff:

Revision 3 (+2402 -534)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/audio.py
	reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-regions-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-spectrogram-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-timeline-3.2.0.min.js
	reviewboard/static/rb/css/assets/icons.less
	7 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/ui/audio.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```
reviewboard/reviews/ui/audio.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F821 undefined name 'crop_image'
```

JSHint

```
Warning: Showing 30 of 204 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)

The issue has been resolved. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1396
 Missing semicolon.
```

Summary:

WIP: Added audio review UI.

Added audio review UI.

Description:

		Review UI for audio files, with a waveform graph and a spectrogram that can be
		toggled on or off.

		When comparing two different revisions, the old revision will be rendered
		first, and the new revision will be underneath it. Each revision has its own
		set of controls as well, and both revisions can be concurrently played.

		Comments can be added by dragging a region of the waveform graph, which will
~		pop up a dialog where the user can add in a comment.
	~	pop up a dialog where the user can add in a comment. After creating the comment,
	+	it will be added to the waveform graph.
	+
	+	Hovering over a comment region on the waveform graph will show details about it
	+	in a tooltip, similar to other review UIs. When a comment region is clicked, it
	+	will allow the user to edit or delete their comment if the shift key is not
	+	pressed. If the shift key is pressed, then the audio player will play just the
	+	selected region.
	+
	+	As of now, there are unit tests, but I can't get them to run due to the
	+	javascript unit test runner seemingly being broken.

Testing Done:

	+	Tested manually with Python2.7 and Python3.6 with a short audio file.
	+	Tested manually with Python2.7 with a long audio file.
	+	Tested the diff viewer manually with Python2.7 and Python3.6.

Commits:

Summary	ID	Author
started on audio player	b9e3f1766232a3cb58ea71fe5fa9d062062ffa40	amalik2
Added volume slider	5c993bb8f3c2dc3540dbdc7b6b8c663ad7ce9c0a	amalik2
more work on audio review ui	0f3cf9197eb8c45b607e02afaa3270e28ac9f7d6	amalik2
Added review UI for audio files.	cf56460dbeacd08f3e852183b01bc0b39d1d2a1e	amalik2

Diff:

Revision 4 (+3014 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/audio.py
	reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-regions-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-spectrogram-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-timeline-3.2.0.min.js
	reviewboard/static/rb/css/assets/icons.less
	10 more

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 204 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)

An issue was opened. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1396
 Missing semicolon.
```

Description:

		Review UI for audio files, with a waveform graph and a spectrogram that can be
		toggled on or off.

		When comparing two different revisions, the old revision will be rendered
		first, and the new revision will be underneath it. Each revision has its own
		set of controls as well, and both revisions can be concurrently played.

		Comments can be added by dragging a region of the waveform graph, which will
		pop up a dialog where the user can add in a comment. After creating the comment,
		it will be added to the waveform graph.

		Hovering over a comment region on the waveform graph will show details about it
		in a tooltip, similar to other review UIs. When a comment region is clicked, it
		will allow the user to edit or delete their comment if the shift key is not
		pressed. If the shift key is pressed, then the audio player will play just the
		selected region.
-
-		As of now, there are unit tests, but I can't get them to run due to the
-		javascript unit test runner seemingly being broken.

Testing Done:

		Tested manually with Python2.7 and Python3.6 with a short audio file.
		Tested manually with Python2.7 with a long audio file.
		Tested the diff viewer manually with Python2.7 and Python3.6.
	+	Ran JavaScript unit tests with Python2.7.

Commits:

	Summary	ID	Author
	Added review UI for audio files.	cf56460dbeacd08f3e852183b01bc0b39d1d2a1e	amalik2
	Added review UI for audio files.	ada1ddf9550498dc18b74134d8476c52746fd310	amalik2

Diff:

Revision 5 (+3172 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/audio.py
	reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-regions-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-spectrogram-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-timeline-3.2.0.min.js
	reviewboard/static/rb/css/assets/icons.less
	10 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 206 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)

An issue was opened. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1396
 Missing semicolon.
```

Commits:

	Summary	ID	Author
	Added review UI for audio files.	ada1ddf9550498dc18b74134d8476c52746fd310	amalik2
	Added review UI for audio files.	cb684a5f2f50025ad8121f29ce0574031b8134c4	amalik2

Diff:

Revision 6 (+3172 -2)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/audio.py
	reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-regions-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-spectrogram-3.2.0.min.js
	reviewboard/static/lib/js/wavesurferjs-timeline-3.2.0.min.js
	reviewboard/static/rb/css/assets/icons.less
	10 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 206 failures.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 52
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 97
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 159
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 212
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 213
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 44413
 A leading decimal point can be confused with a dot: '.5'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 284
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 395
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 492
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 493
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 524
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 667
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 668
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 709
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 736
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 762
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 881
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 890
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 905
 Expected '{' and instead saw 'r'.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 936
 Missing semicolon.
```

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)

An issue was opened. Show all issues

Col: 913
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (e)

reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 960
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1027
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1048
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1071
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1139
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1156
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1314
 Missing semicolon.
```
reviewboard/static/lib/js/wavesurferjs-3.2.0.min.js (Diff revision 6)
An issue was opened. Show all issues
```
Col: 1396
 Missing semicolon.
```