Summary

Split the administration forms into multiple files.

Review Request #10796 — Created Nov. 11, 2019 and submitted Dec. 28, 2019, 1:15 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Commit

b70d502...

Reviewers

Groups

reviewboard

People

Description

This splits up reviewboard.admin.forms into multiple files, making it
easier to maintain as new forms and utility classes are added. It
doesn't change any logic or formatting, with the exception of adding
module-level docstrings. An upcoming change will bring these classes
up-to-date with our modern coding and doc standards.

This is in preparation for an upcoming change that will add classes for
helping transition Django's idea of Change Form fieldsets and fields to
what we need for the new admin UI.

Testing Done

Unit tests pass.

Manually tested every settings form that moved.

Issues

Description	From	Last Updated
E722 do not use bare except'	reviewbot	Nov. 11, 2019, 4:44 p.m.
E722 do not use bare except'	reviewbot	Nov. 11, 2019, 4:44 p.m.
W391 blank line at end of file	reviewbot	Nov. 11, 2019, 4:44 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/email_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/admin/forms/general_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E722 do not use bare except'
```
reviewboard/admin/forms/search_settings.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (5e986ed)