Summary

Implement archive review UI.

Review Request #10794 — Created Nov. 9, 2019 and updated Dec. 3, 2019, 3:29 p.m.

Information

Owner

perplex

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Currently there is no binary file support for RB, exluding my other
changes. With this arhive files can be posted and reviewed at a
basic level. Reviewers can look through a repersentation of the archive
proposed to be submitted. No support for commonenting or presenting the
actual changes is include in this PR as that was out of scope. The
archive is represented as a JSON file tree and does not have any css or
less changes to make it more unified with the rest of RB. These style
changes will need to be included in a later review request. The JSON
file tree is created using a library called JSTree and is currently
under a MIT license, https://github.com/vakata/jstree/. This feature
does require the changes from my other binary file PRs to function.
Specifically: r/10729, r/10728, and one change from r/10766.

Testing Done

Create a test repo and walked through the steps of a review process.
Posted change, look and interacted with change, then shipped change.
Also wrote tests for parsing the archive files; empty, one level,
and multi level archives.

Commits

Summary	ID
base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd
Address comments	c4de14a0d5e5c0bdaf2c61ad580160e6ef24917a
Address comments	5565f90571992d3ef0383f1e2e8889b416c6dc4c

Files

Issues

Description	From	Last Updated
E302 expected 2 blank lines, found 1	reviewbot	Nov. 30, 2019, 2:38 p.m.
F841 local variable 'serialized_comments' is assigned to but never used	reviewbot	Nov. 30, 2019, 2:38 p.m.
W292 no newline at end of file	reviewbot	Nov. 30, 2019, 2:38 p.m.
Col: 46 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:48 p.m.
Col: 29 'obj' is defined but never used.	reviewbot	Nov. 29, 2019, 4:49 p.m.
E401 multiple imports on one line	reviewbot	Nov. 30, 2019, 2:40 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 30, 2019, 2:40 p.m.
F841 local variable 'serialized_comments' is assigned to but never used	reviewbot	Nov. 30, 2019, 2:40 p.m.
W292 no newline at end of file	reviewbot	Nov. 30, 2019, 2:40 p.m.
Col: 13 Do not use 'new' for side effects.	reviewbot	Nov. 29, 2019, 4:50 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Nov. 30, 2019, 2:41 p.m.
E401 multiple imports on one line	reviewbot	Nov. 30, 2019, 2:41 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 30, 2019, 2:41 p.m.
F841 local variable 'serialized_comments' is assigned to but never used	reviewbot	Nov. 30, 2019, 2:41 p.m.
E265 block comment should start with '# '	reviewbot	Nov. 30, 2019, 2:41 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 30, 2019, 2:41 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 30, 2019, 2:41 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 99 Expected '!==' and instead saw '!='.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 173 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 174 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 677 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 678 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 716 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 802 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 803 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 999 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1000 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1111 Expected '{' and instead saw 'try'.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1121 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1149 Expected '{' and instead saw 'try'.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1196 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1385 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1389 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1431 Expected '===' and instead saw '=='.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1500 Confusing use of '!'.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1688 Confusing use of '!'.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1728 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1757 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1887 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 1888 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 2267 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 2268 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 2331 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 2332 Missing semicolon.	reviewbot	Nov. 29, 2019, 4:52 p.m.
Col: 2403 Expected '{' and instead saw 'this'.	reviewbot	Nov. 29, 2019, 4:53 p.m.
Col: 2558 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 29, 2019, 4:53 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 30, 2019, 3:45 p.m.
W292 no newline at end of file	reviewbot	Nov. 30, 2019, 3:45 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 99 Expected '!==' and instead saw '!='.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 173 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 677 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 678 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 716 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 802 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 803 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 999 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1000 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1111 Expected '{' and instead saw 'try'.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1121 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1149 Expected '{' and instead saw 'try'.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1196 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 174 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1385 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1389 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1431 Expected '===' and instead saw '=='.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1500 Confusing use of '!'.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1688 Confusing use of '!'.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1728 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1757 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1888 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2267 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2268 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2331 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2332 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2403 Expected '{' and instead saw 'this'.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 2558 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:46 p.m.
Col: 1887 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:47 p.m.
The rest of this file is sorted.	brennie	Dec. 1, 2019, 1:50 p.m.
I think you copied this docstring and did update it.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing file-level docstring.	brennie	Dec. 1, 2019, 1:54 p.m.
Missing class docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
TODO.	brennie	Dec. 1, 2019, 1:50 p.m.
nit: blank line between these.	brennie	Dec. 1, 2019, 1:50 p.m.
Missing docstring.	brennie	Dec. 1, 2019, 1:50 p.m.
nit: blank line between these.	brennie	Dec. 1, 2019, 1:51 p.m.
Missing docstring. Typo: "recurse"	brennie	Dec. 1, 2019, 1:51 p.m.
nit: blank line between these.	brennie	Dec. 1, 2019, 1:51 p.m.
nit: add a trailing comma	brennie	Dec. 1, 2019, 1:51 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Nov. 30, 2019, 3:58 p.m.
Col: 99 Expected '!==' and instead saw '!='.	reviewbot	Nov. 30, 2019, 3:58 p.m.
Col: 173 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:58 p.m.
Col: 174 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 677 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 678 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 716 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 802 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 803 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 999 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1000 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1111 Expected '{' and instead saw 'try'.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1121 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1149 Expected '{' and instead saw 'try'.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1196 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1385 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1389 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1431 Expected '===' and instead saw '=='.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1500 Confusing use of '!'.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1688 Confusing use of '!'.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1728 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1757 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1887 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 1888 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2267 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2268 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2331 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2332 Missing semicolon.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2403 Expected '{' and instead saw 'this'.	reviewbot	Nov. 30, 2019, 3:59 p.m.
Col: 2558 Expected an assignment or function call and instead saw an expression.	reviewbot	Nov. 30, 2019, 3:59 p.m.
We don't need to specify empty initialize methods	brennie	Dec. 1, 2019, 1:51 p.m.
nit: remove this line.	brennie	Dec. 1, 2019, 1:51 p.m.
nit: remove this line.	brennie	Dec. 1, 2019, 1:51 p.m.
Leftover debug logging?	brennie	Dec. 1, 2019, 1:51 p.m.
Since reviewboard already uses fontawesome which has its own loading spinners, it may be better to replace the occurrences of …	amalik2	Dec. 2, 2019, 11:47 p.m.
I'm most likely wrong about this since I know very little about licensing but I think that even for permissive …	amalik2	Dec. 2, 2019, 11:46 p.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 99 Expected '!==' and instead saw '!='.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 173 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 174 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 677 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 678 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 716 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 802 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 803 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 999 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1000 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1111 Expected '{' and instead saw 'try'.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1121 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1149 Expected '{' and instead saw 'try'.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1196 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1385 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1389 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1431 Expected '===' and instead saw '=='.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1500 Confusing use of '!'.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1688 Confusing use of '!'.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1728 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1757 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1887 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 1888 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 2267 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 2268 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:56 p.m.
Col: 2331 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:57 p.m.
Col: 2332 Missing semicolon.	reviewbot	Dec. 1, 2019, 1:57 p.m.
Col: 2403 Expected '{' and instead saw 'this'.	reviewbot	Dec. 1, 2019, 1:57 p.m.
Col: 2558 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 1, 2019, 1:57 p.m.
diffAgainstArchiveMetadata should also be mentioned in the docstring	amalik2	Dec. 3, 2019, 10:09 a.m.
Should this be mode? The subclasses of BaseArchiveView define mode instead of node.	amalik2	Dec. 3, 2019, 10:09 a.m.
Did you define CSS classes anywhere for the different subclasses of BaseArchiveView? I can't find anything by doing a search …	amalik2	Dec. 2, 2019, 11:43 p.m.
I'm curious as to how this works... does jstree modify the String prototype to add a jstree method to it?	amalik2	Dec. 2, 2019, 11:36 p.m.
Single quotes should be used	amalik2	Dec. 3, 2019, 10:09 a.m.
Where/how is this used? I don't see any usages in this file	amalik2	Dec. 3, 2019, 10:09 a.m.
Where/how is this used? I don't see any usages in this file	amalik2	Dec. 3, 2019, 10:09 a.m.
Where/how is this used? I don't see any usages in this file	amalik2	Dec. 3, 2019, 10:09 a.m.
What is this used for?	amalik2	Dec. 3, 2019, 10:08 a.m.
Is there a revision selector slider that gets rendered somewhere? (the text/image based review UIs have it)	amalik2	Dec. 3, 2019, 10:08 a.m.
Not a huge deal but in general, using Boolean(value) is easier to understand than !!value	amalik2	Dec. 3, 2019, 10:11 a.m.
Wouldn't this crash if there is a diff type mismatch? this._archiveView looks like it would be undefined in that situation.	amalik2	Dec. 2, 2019, 11:36 p.m.
To be more consistent with the other CSS files, it would be better to rename the css file to something …	amalik2	Dec. 3, 2019, 10:13 a.m.
Col: 39 Expected '===' and instead saw '=='.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 99 Expected '!==' and instead saw '!='.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 173 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 174 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 677 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 678 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 716 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 802 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 803 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 999 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1000 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1111 Expected '{' and instead saw 'try'.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1121 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1149 Expected '{' and instead saw 'try'.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1196 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1385 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:58 a.m.
Col: 1389 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1431 Expected '===' and instead saw '=='.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1500 Confusing use of '!'.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1688 Confusing use of '!'.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1728 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1757 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1887 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 1888 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2267 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2268 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2331 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2332 Missing semicolon.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2403 Expected '{' and instead saw 'this'.	reviewbot	Dec. 3, 2019, 10:59 a.m.
Col: 2558 Expected an assignment or function call and instead saw an expression.	reviewbot	Dec. 3, 2019, 10:59 a.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/ui/archive.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/ui/archive.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'serialized_comments' is assigned to but never used
```
reviewboard/reviews/ui/archive.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```

JSHint

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 46
 Missing semicolon.
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 29
 'obj' is defined but never used.
```

Commits:

	Summary	ID
	base framework for archive review ui	8cde8e072e6ecb8b89fbbf5f1c8dff80c79d4482
	base framework for archive review ui	a124db6397d047737a4c049f59ba4e667963bfbe
	Move parsing of archives to backend	8dd1f82aaca9f468f7dc25a8be8b2b87677961a1

Diff:

Revision 2 (+5587 -5089)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/views.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/rb/js/models/archiveReviewableModel.es6.js
	reviewboard/static/rb/js/views/archiveReviewableView.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/ui/archive.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E401 multiple imports on one line
```
reviewboard/reviews/ui/archive.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/ui/archive.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F841 local variable 'serialized_comments' is assigned to but never used
```
reviewboard/reviews/ui/archive.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

JSHint

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 13
 Do not use 'new' for side effects.
```

Commits:

	Summary	ID
	base framework for archive review ui	a124db6397d047737a4c049f59ba4e667963bfbe
	Move parsing of archives to backend	8dd1f82aaca9f468f7dc25a8be8b2b87677961a1
	base framework for archive review ui	a124db6397d047737a4c049f59ba4e667963bfbe
	Move parsing of archives to backend	8dd1f82aaca9f468f7dc25a8be8b2b87677961a1
	Implement rendering of archives with JSTree library	ff10db2261cb13ad5e52bd56240b8cce0564e70e

Diff:

Revision 3 (+5730 -5144)

Show changes

	reviewboard/staticbundles.py
	reviewboard/attachments/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/lib/css/jstree/32px.png
	reviewboard/static/lib/css/jstree/40px.png
	reviewboard/static/lib/css/jstree/style.min.css
	4 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/attachments/managers.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E401 multiple imports on one line
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F841 local variable 'serialized_comments' is assigned to but never used
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/reviews/ui/archive.py (Diff revision 3)
The issue has been resolved. Show all issues
```
E226 missing whitespace around arithmetic operator
```

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 99
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 173
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 174
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 677
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 678
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 716
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 802
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 803
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 999
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1000
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1111
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1121
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1149
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1196
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1385
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1389
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1431
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1500
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1688
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1728
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1757
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1887
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 1888
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2267
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2268
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2331
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2332
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2403
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 2558
 Expected an assignment or function call and instead saw an expression.
```

Summary:

WIP: Archive Review UI

Archive Review UI

Description:

~		base framework for archive review ui
	~	Currently there is no binary file support for RB, exluding my other changes. With this arhive files can be posted and reviewed at a basic level. Reviewers can look through a repersentation of the archive proposed to be submitted. No support for commonenting or presenting the actual changes is include in this PR as that was out of scope. The archive is represented as a JSON file tree and does not have any css or less changes to make it more unified with the rest of RB. These style changes will need to be included in a later review request. The JSON file tree is created using a library called JSTree and is currently under a MIT license, https://github.com/vakata/jstree/. This feature does require the changes from my other binary file PRs to function. Specifically: r/10729, r/10728, and one change from r/10766.

Testing Done:

Create a test repo and walked through the steps of a review process. Posted change, look and interacted with change, then shipped change. Also wrote tests for parsing the archive files; empty, one level, and multi level archives.

Commits:

	Summary	ID
	base framework for archive review ui	a124db6397d047737a4c049f59ba4e667963bfbe
	Move parsing of archives to backend	8dd1f82aaca9f468f7dc25a8be8b2b87677961a1
	Implement rendering of archives with JSTree library	ff10db2261cb13ad5e52bd56240b8cce0564e70e
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06

Diff:

Revision 4 (+5847 -5165)

Show changes

	dev-requirements.txt
	reviewboard/staticbundles.py
	reviewboard/attachments/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_archive_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/lib/css/jstree/32px.png
	6 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```
reviewboard/reviews/ui/archive.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E226 missing whitespace around arithmetic operator
```

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 99
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 173
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 677
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 678
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 716
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 802
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 803
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 999
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1000
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1111
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1121
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1149
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1196
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 174
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1385
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1389
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1431
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1500
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1688
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1728
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1757
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1888
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2267
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2268
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2331
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2332
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2403
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 2558
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 1887
 Missing semicolon.
```

Commits:

	Summary	ID
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd

Diff:

Revision 5 (+5851 -5167)

Show changes

	dev-requirements.txt
	reviewboard/staticbundles.py
	reviewboard/attachments/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_archive_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/lib/css/jstree/32px.png
	6 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 99
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 173
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 174
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 677
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 678
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 716
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 802
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 803
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 999
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1000
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1111
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1121
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1149
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1196
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1385
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1389
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1431
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1500
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1688
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1728
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1757
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1887
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 1888
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2267
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2268
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2331
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2332
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2403
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 2558
 Expected an assignment or function call and instead saw an expression.
```

Summary:: Archive Review UI
Implement archive review UI.

Description:: ~
Currently there is no binary file support for RB, exluding my other changes. With this arhive files can be posted and reviewed at a basic level. Reviewers can look through a repersentation of the archive proposed to be submitted. No support for commonenting or presenting the actual changes is include in this PR as that was out of scope. The archive is represented as a JSON file tree and does not have any css or less changes to make it more unified with the rest of RB. These style changes will need to be included in a later review request. The JSON file tree is created using a library called JSTree and is currently under a MIT license, https://github.com/vakata/jstree/. This feature does require the changes from my other binary file PRs to function. Specifically: r/10729, r/10728, and one change from r/10766.
~
Currently there is no binary file support for RB, exluding my other
+ changes. With this arhive files can be posted and reviewed at a
+ basic level. Reviewers can look through a repersentation of the archive
+ proposed to be submitted. No support for commonenting or presenting the
+ actual changes is include in this PR as that was out of scope. The
+ archive is represented as a JSON file tree and does not have any css or
+ less changes to make it more unified with the rest of RB. These style
+ changes will need to be included in a later review request. The JSON
+ file tree is created using a library called JSTree and is currently
+ under a MIT license, https://github.com/vakata/jstree/. This feature
+ does require the changes from my other binary file PRs to function.
+ Specifically: r/10729, r/10728, and one change from r/10766.
Testing Done:: ~
Create a test repo and walked through the steps of a review process. Posted change, look and interacted with change, then shipped change. Also wrote tests for parsing the archive files; empty, one level, and multi level archives.
~
Create a test repo and walked through the steps of a review process.
+ Posted change, look and interacted with change, then shipped change.
+ Also wrote tests for parsing the archive files; empty, one level,
+ and multi level archives.

dev-requirements.txt (Diff revision 5)
The issue has been resolved. Show all issues
```
The rest of this file is sorted.
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 5)
The issue has been resolved. Show all issues
```
I think you copied this docstring and did update it.
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/tests/test_archive_review_ui.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing file-level docstring.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing class docstring.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
TODO.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: blank line between these.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: blank line between these.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing docstring.
Typo: "recurse"
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: blank line between these.
```
reviewboard/reviews/ui/archive.py (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: add a trailing comma
```

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 5)

The issue has been resolved. Show all issues

We don't need to specify empty initialize methods

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: remove this line.
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 5)
The issue has been resolved. Show all issues
```
nit: remove this line.
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 5)
The issue has been resolved. Show all issues
```
Leftover debug logging?
```

Commits:

	Summary	ID
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd
	Address comments	c4de14a0d5e5c0bdaf2c61ad580160e6ef24917a

Diff:

Revision 6 (+5907 -5187)

Show changes

	dev-requirements.txt
	reviewboard/staticbundles.py
	reviewboard/attachments/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_archive_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/lib/css/jstree/32px.png
	6 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 99
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 173
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 174
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 677
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 678
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 716
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 802
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 803
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 999
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1000
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1111
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1121
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1149
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1196
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1385
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1389
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1431
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1500
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1688
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1728
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1757
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1887
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 1888
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2267
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2268
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2331
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2332
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2403
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 2558
 Expected an assignment or function call and instead saw an expression.
```

Fix it!

reviewboard/static/lib/css/jstree/style.min.css (Diff revision 6)

The issue has been dropped. Show all issues

Since reviewboard already uses fontawesome which has its own loading spinners, it may be better to replace the occurrences of background:url("throbber.gif") in this CSS file with the fontawesome equivalent. That way, you wouldn't need to add in the throbber.gif file

perplex Dec. 2, 2019, 11:48 p.m.

I don't want to diverge the local copy of the library from what is being produced.

reviewboard/static/lib/js/jstree.min.js (Diff revision 6)

The issue has been dropped. Show all issues

I'm most likely wrong about this since I know very little about licensing but I think that even for permissive licenses like MIT, you need to put the entire license text where you use the code. You probably should verify this with the mentors

perplex Dec. 2, 2019, 11:48 p.m.

From what I understand MIT licenses only require the license where the software is not where it is used.

https://opensource.org/licenses/MIT

reviewboard/static/rb/js/models/archiveReviewableModel.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
diffAgainstArchiveMetadata should also be mentioned in the docstring
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Should this be mode? The subclasses of BaseArchiveView define mode instead of node.
```

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)

The issue has been dropped. Show all issues

Did you define CSS classes anywhere for the different subclasses of BaseArchiveView? I can't find anything by doing a search for 'archive-diff-'

perplex Dec. 2, 2019, 11:48 p.m.

As stated in the description and in the demo video alot of work will need to be done to actually bring a more unifed look to the archive diffing. For that reason I'm not including style changes at this time.

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)

An issue was opened. Show all issues

I'm curious as to how this works... does jstree modify the String prototype to add a jstree method to it?

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Single quotes should be used
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Where/how is this used? I don't see any usages in this file
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Where/how is this used? I don't see any usages in this file
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Where/how is this used? I don't see any usages in this file
```
reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
What is this used for?
```

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)

The issue has been dropped. Show all issues

Is there a revision selector slider that gets rendered somewhere? (the text/image based review UIs have it)

perplex Dec. 3, 2019, 11:08 a.m.

I believe that is handled by the file attachment class. The mentions to a slider in a the image reviewable are for the onion and diffing sliders that overlap images.

amalik2 Dec. 3, 2019, 3:29 p.m.

https://github.com/reviewboard/reviewboard/blob/master/reviewboard/static/rb/js/views/imageReviewableView.es6.js#L990

I had to explicitly include this in my code also to get it to show up. You can test this by creating a file attachment and updating it. When viewing details about the attachment, it should show the revision selector in the review header

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)
The issue has been resolved. Show all issues
```
Not a huge deal but in general, using Boolean(value) is easier to understand than !!value
```
1. PE
  
  perplex Dec. 3, 2019, 11:08 a.m.
  This the same as the image reviewable view.

reviewboard/static/rb/js/views/archiveReviewableView.es6.js (Diff revision 6)

An issue was opened. Show all issues

Wouldn't this crash if there is a diff type mismatch? this._archiveView looks like it would be undefined in that situation.

reviewboard/staticbundles.py (Diff revision 6)

The issue has been dropped. Show all issues

To be more consistent with the other CSS files, it would be better to rename the css file to something like jstree.min.css, and then move it outside of the jstree folder (and remove the jstree folder altogether)

perplex Dec. 3, 2019, 11:08 a.m.

This is consistent with what is done in the JS folder. Look at the flot folder in static/lib/js.

Commits:

	Summary	ID
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd
	Address comments	c4de14a0d5e5c0bdaf2c61ad580160e6ef24917a
	base framework for archive review ui	f992ac6290d7362341c0b2b8c5c093e819df4d40
	Move parsing of archives to backend	730b85ed79a0b37147f1893cf7ae5377ea7c8b95
	Implement rendering of archives with JSTree library	4c0eef1642bedf4762de12fe84ea2c2cbe085dde
	Add testing and fix some small issues	2ec0d0c00038aa54cf5c8428d63de161210a5e06
	address suggestions	7cda64657498e5996b0bb6696e19ba23c42acebd
	Address comments	c4de14a0d5e5c0bdaf2c61ad580160e6ef24917a
	Address comments	5565f90571992d3ef0383f1e2e8889b416c6dc4c

Diff:

Revision 7 (+5903 -5199)

Show changes

	dev-requirements.txt
	reviewboard/staticbundles.py
	reviewboard/attachments/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_archive_review_ui.py
	reviewboard/reviews/ui/__init__.py
	reviewboard/reviews/ui/archive.py
	reviewboard/static/lib/css/jstree/32px.png
	6 more

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 39
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 99
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 173
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 174
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 677
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 678
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 716
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 802
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 803
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 999
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1000
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1111
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1121
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1149
 Expected '{' and instead saw 'try'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1196
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1385
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1389
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1431
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1500
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1688
 Confusing use of '!'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1728
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1757
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1887
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 1888
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2267
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2268
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2331
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2332
 Missing semicolon.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2403
 Expected '{' and instead saw 'this'.
```
reviewboard/static/lib/js/jstree.min.js (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 2558
 Expected an assignment or function call and instead saw an expression.
```

~		Currently there is no binary file support for RB, exluding my other changes. With this arhive files can be posted and reviewed at a basic level. Reviewers can look through a repersentation of the archive proposed to be submitted. No support for commonenting or presenting the actual changes is include in this PR as that was out of scope. The archive is represented as a JSON file tree and does not have any css or less changes to make it more unified with the rest of RB. These style changes will need to be included in a later review request. The JSON file tree is created using a library called JSTree and is currently under a MIT license, https://github.com/vakata/jstree/. This feature does require the changes from my other binary file PRs to function. Specifically: r/10729, r/10728, and one change from r/10766.
	~	Currently there is no binary file support for RB, exluding my other
	+	changes. With this arhive files can be posted and reviewed at a
	+	basic level. Reviewers can look through a repersentation of the archive
	+	proposed to be submitted. No support for commonenting or presenting the
	+	actual changes is include in this PR as that was out of scope. The
	+	archive is represented as a JSON file tree and does not have any css or
	+	less changes to make it more unified with the rest of RB. These style
	+	changes will need to be included in a later review request. The JSON
	+	file tree is created using a library called JSTree and is currently
	+	under a MIT license, https://github.com/vakata/jstree/. This feature
	+	does require the changes from my other binary file PRs to function.
	+	Specifically: r/10729, r/10728, and one change from r/10766.

~		Create a test repo and walked through the steps of a review process. Posted change, look and interacted with change, then shipped change. Also wrote tests for parsing the archive files; empty, one level, and multi level archives.
	~	Create a test repo and walked through the steps of a review process.
	+	Posted change, look and interacted with change, then shipped change.
	+	Also wrote tests for parsing the archive files; empty, one level,
	+	and multi level archives.